You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/06/26 21:51:53 UTC
[GitHub] [druid] surekhasaharan opened a new pull request #10087: Filter on metrics doc
surekhasaharan opened a new pull request #10087:
URL: https://github.com/apache/druid/pull/10087
Adding a note to query filters docs about filters on metrics are possible now. If someone has a usecase to filter on metrics, these docs make it confusing and seem to suggest that filters are only supported on dimensions in Druid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #10087: Filter on metrics doc
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #10087:
URL: https://github.com/apache/druid/pull/10087#discussion_r446427292
##########
File path: docs/querying/filters.md
##########
@@ -30,6 +30,10 @@ sidebar_label: "Filters"
A filter is a JSON object indicating which rows of data should be included in the computation for a query. It’s essentially the equivalent of the WHERE clause in SQL. Apache Druid supports the following types of filters.
+**Note**
+
+Filters are commonly applied on dimensions, but can be applied on metrics as well.
Review comment:
Should this link to `aggregations.md#filtered-aggregator`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #10087: Filter on metrics doc
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #10087:
URL: https://github.com/apache/druid/pull/10087#discussion_r446427292
##########
File path: docs/querying/filters.md
##########
@@ -30,6 +30,10 @@ sidebar_label: "Filters"
A filter is a JSON object indicating which rows of data should be included in the computation for a query. It’s essentially the equivalent of the WHERE clause in SQL. Apache Druid supports the following types of filters.
+**Note**
+
+Filters are commonly applied on dimensions, but can be applied on metrics as well.
Review comment:
Should this link to `aggregations.md#filtered-aggregator` or like 'having' or something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #10087: Filter on metrics doc
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #10087:
URL: https://github.com/apache/druid/pull/10087
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] surekhasaharan commented on a change in pull request #10087: Filter on metrics doc
Posted by GitBox <gi...@apache.org>.
surekhasaharan commented on a change in pull request #10087:
URL: https://github.com/apache/druid/pull/10087#discussion_r446437576
##########
File path: docs/querying/filters.md
##########
@@ -30,6 +30,10 @@ sidebar_label: "Filters"
A filter is a JSON object indicating which rows of data should be included in the computation for a query. It’s essentially the equivalent of the WHERE clause in SQL. Apache Druid supports the following types of filters.
+**Note**
+
+Filters are commonly applied on dimensions, but can be applied on metrics as well.
Review comment:
In my head, i was thinking filtering on aggregates, like filtering on metrics in a groupby. Sure, adding a link to those would be useful here.
Separately, does anyone know if we started supporting filtering metrics since a particular release version which should be specified here ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #10087: Filter on metrics doc
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #10087:
URL: https://github.com/apache/druid/pull/10087#discussion_r446427292
##########
File path: docs/querying/filters.md
##########
@@ -30,6 +30,10 @@ sidebar_label: "Filters"
A filter is a JSON object indicating which rows of data should be included in the computation for a query. It’s essentially the equivalent of the WHERE clause in SQL. Apache Druid supports the following types of filters.
+**Note**
+
+Filters are commonly applied on dimensions, but can be applied on metrics as well.
Review comment:
Should this link to `aggregations.md#filtered-aggregator` or like 'having' or something? Or do you mean when the column that was ingested as a metric is used as normal column instead of part of an aggregation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org