[GitHub] [pulsar] merlimat commented on a change in pull request #4071: [Issue 2461][pulsar-client-cpp] Modified CMake files and source to enable compilation on Windows

[GitBox <gi...@apache.org>]

merlimat commented on a change in pull request #4071: [Issue 2461][pulsar-client-cpp] Modified CMake files and source to enable compilation on Windows
URL: https://github.com/apache/pulsar/pull/4071#discussion_r276858339
 
 

 ##########
 File path: pulsar-client-cpp/lib/Backoff.cc
 ##########
 @@ -25,8 +25,11 @@ Backoff::Backoff(const TimeDuration& initial, const TimeDuration& max, const Tim
       max_(max),
       next_(initial),
       mandatoryStopMade_(false),
-      mandatoryStop_(mandatoryStop),
-      randomSeed_(time(NULL)) {}
+      mandatoryStop_(mandatoryStop)
+#ifndef _MSC_VER
 
 Review comment:
   Maybe we could use `boost::random` to get a portable version of this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services