[jira] [Commented] (HIVE-20160) Do Not Print StackTraces to STDERR in OperatorFactory

["Peter Vary (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-20160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16705682#comment-16705682 ] 

Peter Vary commented on HIVE-20160:
-----------------------------------

[~belugabehr]: The current consensus is that we can commit only if all of the tests are green. We have to rerun the pre-commit until we have a green run. For flaky tests we should fix/disable/rerun with the appropriate annotation. 
Thanks for your efforts! 
Peter 

> Do Not Print StackTraces to STDERR in OperatorFactory
> -----------------------------------------------------
>
>                 Key: HIVE-20160
>                 URL: https://issues.apache.org/jira/browse/HIVE-20160
>             Project: Hive
>          Issue Type: Improvement
>          Components: Query Processor
>    Affects Versions: 3.0.0, 4.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>              Labels: newbie, noob
>         Attachments: HIVE-20160.1.patch, HIVE-20160.1.patch
>
>
> https://github.com/apache/hive/blob/ac6b2a3fb195916e22b2e5f465add2ffbcdc7430/ql/src/java/org/apache/hadoop/hive/ql/exec/OperatorFactory.java#L158
> {code}
>     } catch (Exception e) {
>       e.printStackTrace();
>       throw new HiveException(...
> {code}
> Do not print the stack trace.  The error is being wrapped in a HiveException.  Allow the code catching this exception to print the error to a logger instead of dumping it here to STDERR.  There are several instances of this in the class.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)