[GitHub] [airflow] potiuk commented on a diff in pull request #23747: Remove Tableau from Salesforce provider

[GitBox <gi...@apache.org>]

potiuk commented on code in PR #23747:
URL: https://github.com/apache/airflow/pull/23747#discussion_r910866167


##########
docs/apache-airflow-providers-salesforce/index.rst:
##########
@@ -82,28 +82,8 @@ PIP package              Version required
 ``apache-airflow``       ``>=2.1.0``
 ``pandas``               ``>=0.17.1``
 ``simple-salesforce``    ``>=1.0.0``
-``tableauserverclient``
 =======================  ==================
 
-Cross provider package dependencies

Review Comment:
   This is all good in general. We have "addional extra" - if somoene wants tableau they should install salesforce provider with `["tableau"]` extra (or install `[tableau]' extra in airflow or install `apache-airflow-providers-extra'. But I agree we should add a note in the chanelog of salesforce. And answering the question of @ashb below - this is described actually in changelog.rst of each provider (kind of preparation to make them fully independent and splittable): 
   
   https://raw.githubusercontent.com/apache/airflow/main/airflow/providers/salesforce/CHANGELOG.rst
   
   ```
   .. NOTE TO CONTRIBUTORS:
      Please, only add notes to the Changelog just below the "Changelog" header when there are some breaking changes
      and you want to add an explanation to the users on how they are supposed to deal with them.
      The changelog is updated and maintained semi-automatically by release manager.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org