You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/05/08 07:14:00 UTC
[jira] [Commented] (HDFS-16965) Add switch to decide whether to enable native codec.
[ https://issues.apache.org/jira/browse/HDFS-16965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17720416#comment-17720416 ]
ASF GitHub Bot commented on HDFS-16965:
---------------------------------------
YuanbenWang commented on code in PR #5520:
URL: https://github.com/apache/hadoop/pull/5520#discussion_r1187104682
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/CodecUtil.java:
##########
@@ -170,8 +174,14 @@ private static String[] getRawCoderNames(
private static RawErasureEncoder createRawEncoderWithFallback(
Configuration conf, String codecName, ErasureCoderOptions coderOptions) {
+ boolean ISALEnabled = conf.getBoolean(IO_ERASURECODE_CODEC_NATIVE_ENABLED_KEY,
+ IO_ERASURECODE_CODEC_NATIVE_ENABLED_DEFAULT);
String[] rawCoderNames = getRawCoderNames(conf, codecName);
for (String rawCoderName : rawCoderNames) {
+ if (!ISALEnabled && rawCoderName.contains("native")) {
+ LOG.info("Disable the encoder with ISA-L.");
Review Comment:
@cnauroth Thank you for your suggestion. I'v updated the code and changed the log level to debug. Could you review this please?
> Add switch to decide whether to enable native codec.
> ----------------------------------------------------
>
> Key: HDFS-16965
> URL: https://issues.apache.org/jira/browse/HDFS-16965
> Project: Hadoop HDFS
> Issue Type: New Feature
> Components: erasure-coding
> Affects Versions: 3.3.4
> Reporter: WangYuanben
> Priority: Minor
> Labels: pull-request-available
>
> Sometimes we need to create codec without ISA-L, while priority is given to native codec by default. So it is necessary to add switch to decide whether to enable native codec.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org