[GitHub] [druid] abhishekagarwal87 commented on pull request #11302: Add integer parsing in HiLoQueryLaningStrategy

[GitBox <gi...@apache.org>]

abhishekagarwal87 commented on pull request #11302:
URL: https://github.com/apache/druid/pull/11302#issuecomment-848906949


   > Is this a frequently occurring error?
   > Why would a user set the priority as a string?
   
   User is not setting the priority as String. I think below is what is happening
    - all the entries in the file are being deserialized into `Properties` object. So even integer etc is being parsed as String. 
    - If that was not the case, such non-string entries will be filtered out in https://github.com/apache/druid/blob/master/core/src/main/java/org/apache/druid/guice/JsonConfigurator.java#L92 (properties.getPropertyValue returns null if value is not of string type)
    
   Usually, the properties read will be translated into a Java object and any primitive types in the Java class will be parsed into numbers if required e.g. `SegmentLoaderConfig`. `DefaultQueryConfig` is special though since it has just a map `Map<String, Object>` so it's up to the caller to do the required parsing. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org