You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/22 15:11:43 UTC
[GitHub] [airflow] ryw opened a new pull request #6879: [AIRFLOW-XXXX] Adds
.mailmap to coalesce commits in shortlog
ryw opened a new pull request #6879: [AIRFLOW-XXXX] Adds .mailmap to coalesce commits in shortlog
URL: https://github.com/apache/airflow/pull/6879
### Jira
- [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
Running `git shortlog -sne` shows multiple rows per real person, adding a .mailmap
https://git-scm.com/docs/git-shortlog#_mapping_authors
Example in the wild (linux) https://github.com/torvalds/linux/blob/master/.mailmap
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #6879: [AIRFLOW-XXXX] Adds
.mailmap to coalesce commits in shortlog
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #6879: [AIRFLOW-XXXX] Adds .mailmap to coalesce commits in shortlog
URL: https://github.com/apache/airflow/pull/6879
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #6879:
[AIRFLOW-XXXX] Adds .mailmap to coalesce commits in shortlog
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #6879: [AIRFLOW-XXXX] Adds .mailmap to coalesce commits in shortlog
URL: https://github.com/apache/airflow/pull/6879#discussion_r360725223
##########
File path: .mailmap
##########
@@ -0,0 +1,70 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+Arthur Wiedmer <ar...@apache.org> <ar...@arthur-wiedmer.local>
+Arthur Wiedmer <ar...@apache.org> <ar...@airbnb.com>
+Arthur Wiedmer <ar...@apache.org> <ar...@gmail.com>
+Bolke de Bruin <bo...@xs4all.nl> <bo...@Bolkes-MacBook-Pro.local>
+Bolke de Bruin <bo...@xs4all.nl> <bo...@users.noreply.github.com>
+Chris Riccomini <cr...@apache.org> <ch...@wepay.com>
+Chris Riccomini <cr...@apache.org> <cr...@users.noreply.github.com>
+Dan Davydov <dd...@twitter.com> <da...@airbnb.com>
+Daniel Imberman <da...@gmail.com> <da...@astronomer.io>
+Daniel Imberman <da...@gmail.com> <da...@gmail.com>
+Daniel Standish <ds...@users.noreply.github.com>
+Felix Uellendall <fe...@users.noreply.github.com> <fe...@users.noreply.github.com>
+Feng Lu <fe...@fengcloud.hot.corp.google.com> <fe...@google.com>
+Fokko Driesprong <fo...@apache.org> <fo...@driesprong.frl>
+Fokko Driesprong <fo...@apache.org> <fo...@godatadriven.com>
+Gerard Toonstra <gt...@gmail.com>
+Greg Neiheisel <gr...@astronomer.io>
+Jarek Potiuk <ja...@polidea.com> <ex...@users.noreply.github.com>
Review comment:
Are you sure about that name :)? I don't think it's me :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ryw commented on issue #6879: [AIRFLOW-XXXX] Adds
.mailmap to coalesce commits in shortlog
Posted by GitBox <gi...@apache.org>.
ryw commented on issue #6879: [AIRFLOW-XXXX] Adds .mailmap to coalesce commits in shortlog
URL: https://github.com/apache/airflow/pull/6879#issuecomment-568489105
> Just one line (about me :) ) which I am not sure about ...
whoops - fixed that - probably some lines are missing for ppl w/ less commits, but i spent a few hours getting the first two pages (except this error w/ you, Jarek - maybe others)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services