You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2017/12/11 23:06:16 UTC

[kudu-CR] docs: clarify disk failure recovery administration

Andrew Wong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8811


Change subject: docs: clarify disk failure recovery administration
......................................................................

docs: clarify disk failure recovery administration

This patch aims to clarify the disk failure scenarios that are currently
handled and what to do when one is encountered.

For a rendered version, see here:
https://github.com/andrwng/kudu/blob/df_docs/docs/administration.adoc#disk_failure_recovery

Note: the configuration link goes to a .html page instead of a .adoc
page here:
https://kudu.apache.org/docs/configuration.html#directory_configuration

Change-Id: Idb362b277e104839a3aaaa3e94153e93f8b607b3
---
M docs/administration.adoc
1 file changed, 24 insertions(+), 14 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/8811/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb362b277e104839a3aaaa3e94153e93f8b607b3
Gerrit-Change-Number: 8811
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>

[kudu-CR] docs: clarify disk failure recovery administration

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8811 )

Change subject: docs: clarify disk failure recovery administration
......................................................................

docs: clarify disk failure recovery administration

This patch aims to clarify the disk failure scenarios that are currently
handled and what to do when one is encountered.

For a rendered version, see here:
https://github.com/andrwng/kudu/blob/df_docs/docs/administration.adoc#disk_failure_recovery

Note: the configuration link goes to a .html page instead of a .adoc
page here:
https://kudu.apache.org/docs/configuration.html#directory_configuration

Change-Id: Idb362b277e104839a3aaaa3e94153e93f8b607b3
Reviewed-on: http://gerrit.cloudera.org:8080/8811
Tested-by: Kudu Jenkins
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M docs/administration.adoc
1 file changed, 31 insertions(+), 15 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Jean-Daniel Cryans: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/8811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb362b277e104839a3aaaa3e94153e93f8b607b3
Gerrit-Change-Number: 8811
Gerrit-PatchSet: 4
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] docs: clarify disk failure recovery administration

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/8811 )

Change subject: docs: clarify disk failure recovery administration
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/8811/1/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/8811/1/docs/administration.adoc@771
PS1, Line 771:  
nit, double space


http://gerrit.cloudera.org:8080/#/c/8811/1/docs/administration.adoc@796
PS1, Line 796: E1025
Pretty sure that's supposed to be E1205. Have you been manipulating those dates? :)


http://gerrit.cloudera.org:8080/#/c/8811/1/docs/administration.adoc@800
PS1, Line 800: 
Someone who googled for those log lines would wonder about two things: how bad is it to keep my servers running and what do I need to do next? I think we should answer this here for the administrator.



-- 
To view, visit http://gerrit.cloudera.org:8080/8811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb362b277e104839a3aaaa3e94153e93f8b607b3
Gerrit-Change-Number: 8811
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 11 Dec 2017 23:18:44 +0000
Gerrit-HasComments: Yes

[kudu-CR] docs: clarify disk failure recovery administration

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/8811 )

Change subject: docs: clarify disk failure recovery administration
......................................................................


Patch Set 2:

(2 comments)

Good changes. I have a couple of minor suggestions, if you have room in the HTML layout to accommodate them.

http://gerrit.cloudera.org:8080/#/c/8811/2/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/8811/2/docs/administration.adoc@771
PS2, Line 771: releases
nit: Apache Kudu releases


http://gerrit.cloudera.org:8080/#/c/8811/2/docs/administration.adoc@777
PS2, Line 777: Versions
Kudu Releases



-- 
To view, visit http://gerrit.cloudera.org:8080/8811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb362b277e104839a3aaaa3e94153e93f8b607b3
Gerrit-Change-Number: 8811
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 12 Dec 2017 00:00:34 +0000
Gerrit-HasComments: Yes

[kudu-CR] docs: clarify disk failure recovery administration

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Jean-Daniel Cryans, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8811

to look at the new patch set (#3).

Change subject: docs: clarify disk failure recovery administration
......................................................................

docs: clarify disk failure recovery administration

This patch aims to clarify the disk failure scenarios that are currently
handled and what to do when one is encountered.

For a rendered version, see here:
https://github.com/andrwng/kudu/blob/df_docs/docs/administration.adoc#disk_failure_recovery

Note: the configuration link goes to a .html page instead of a .adoc
page here:
https://kudu.apache.org/docs/configuration.html#directory_configuration

Change-Id: Idb362b277e104839a3aaaa3e94153e93f8b607b3
---
M docs/administration.adoc
1 file changed, 31 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/8811/3
-- 
To view, visit http://gerrit.cloudera.org:8080/8811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idb362b277e104839a3aaaa3e94153e93f8b607b3
Gerrit-Change-Number: 8811
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] docs: clarify disk failure recovery administration

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/8811 )

Change subject: docs: clarify disk failure recovery administration
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb362b277e104839a3aaaa3e94153e93f8b607b3
Gerrit-Change-Number: 8811
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 11 Dec 2017 23:37:24 +0000
Gerrit-HasComments: No

[kudu-CR] docs: clarify disk failure recovery administration

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change. ( http://gerrit.cloudera.org:8080/8811 )

Change subject: docs: clarify disk failure recovery administration
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/8811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb362b277e104839a3aaaa3e94153e93f8b607b3
Gerrit-Change-Number: 8811
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 12 Dec 2017 00:25:22 +0000
Gerrit-HasComments: No

[kudu-CR] docs: clarify disk failure recovery administration

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Hello Jean-Daniel Cryans, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/8811

to look at the new patch set (#2).

Change subject: docs: clarify disk failure recovery administration
......................................................................

docs: clarify disk failure recovery administration

This patch aims to clarify the disk failure scenarios that are currently
handled and what to do when one is encountered.

For a rendered version, see here:
https://github.com/andrwng/kudu/blob/df_docs/docs/administration.adoc#disk_failure_recovery

Note: the configuration link goes to a .html page instead of a .adoc
page here:
https://kudu.apache.org/docs/configuration.html#directory_configuration

Change-Id: Idb362b277e104839a3aaaa3e94153e93f8b607b3
---
M docs/administration.adoc
1 file changed, 30 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/11/8811/2
-- 
To view, visit http://gerrit.cloudera.org:8080/8811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idb362b277e104839a3aaaa3e94153e93f8b607b3
Gerrit-Change-Number: 8811
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] docs: clarify disk failure recovery administration

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8811 )

Change subject: docs: clarify disk failure recovery administration
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/8811/1/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/8811/1/docs/administration.adoc@771
PS1, Line 771: B
> nit, double space
Done


http://gerrit.cloudera.org:8080/#/c/8811/1/docs/administration.adoc@796
PS1, Line 796: E1205
> Pretty sure that's supposed to be E1205. Have you been manipulating those d
Actually have no idea how this happened. No :Z


http://gerrit.cloudera.org:8080/#/c/8811/1/docs/administration.adoc@800
PS1, Line 800: 
> Someone who googled for those log lines would wonder about two things: how 
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb362b277e104839a3aaaa3e94153e93f8b607b3
Gerrit-Change-Number: 8811
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 11 Dec 2017 23:34:50 +0000
Gerrit-HasComments: Yes

[kudu-CR] docs: clarify disk failure recovery administration

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8811 )

Change subject: docs: clarify disk failure recovery administration
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/8811/2/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/8811/2/docs/administration.adoc@771
PS2, Line 771: Apache K
> nit: Apache Kudu releases
Done


http://gerrit.cloudera.org:8080/#/c/8811/2/docs/administration.adoc@777
PS2, Line 777: 
> Kudu Releases
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/8811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb362b277e104839a3aaaa3e94153e93f8b607b3
Gerrit-Change-Number: 8811
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 12 Dec 2017 00:02:37 +0000
Gerrit-HasComments: Yes