You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "nicolas de loof (JIRA)" <ji...@codehaus.org> on 2007/11/14 17:47:25 UTC

[jira] Created: (MRM-595) regression : server-side relocation fails

regression : server-side relocation fails
-----------------------------------------

                 Key: MRM-595
                 URL: http://jira.codehaus.org/browse/MRM-595
             Project: Archiva
          Issue Type: Bug
          Components: WebDAV interface
    Affects Versions: 1.0-beta-4
            Reporter: nicolas de loof


1.0-beta-4 introduces a regression in maven1 request handling :

simply try to get :
http://localhost:8080/archiva/repository/internal/servletapi/jars/servletapi-2.4.jar


two causes : 

1. as fetchContentFromProxies MAY change the request pathInfo when relocation occurs, it MUST be called before resource file is build based on request.getLogicalResource().

2. getLogicalResource() is used to get the resource path. The value returned is not affected when the request PathInfo has been changed.

point 2 may require some changes in plexus DavServerRequest : compute the logical resource on-demand, or add a new public method to set it.




-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-595) regression : server-side relocation fails

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter updated MRM-595:
-----------------------------

    Fix Version/s: 1.0

> regression : server-side relocation fails
> -----------------------------------------
>
>                 Key: MRM-595
>                 URL: http://jira.codehaus.org/browse/MRM-595
>             Project: Archiva
>          Issue Type: Bug
>          Components: WebDAV interface
>    Affects Versions: 1.0-beta-4
>            Reporter: nicolas de loof
>             Fix For: 1.0
>
>         Attachments: MRM-595.patch, plexus-webdav-api.patch
>
>
> 1.0-beta-4 introduces a regression in maven1 request handling :
> simply try to get :
> http://localhost:8080/archiva/repository/internal/servletapi/jars/servletapi-2.4.jar
> two causes : 
> 1. as fetchContentFromProxies MAY change the request pathInfo when relocation occurs, it MUST be called before resource file is build based on request.getLogicalResource().
> 2. getLogicalResource() is used to get the resource path. The value returned is not affected when the request PathInfo has been changed.
> point 2 may require some changes in plexus DavServerRequest : compute the logical resource on-demand, or add a new public method to set it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Issue Comment Edited: (MRM-595) regression : server-side relocation fails

Posted by "nicolas de loof (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_113886 ] 

nicolas de loof edited comment on MRM-595 at 11/15/07 3:52 AM:
---------------------------------------------------------------

my patch contains a stupid typo on archiva parent POM for <dependencyManagement> : plexus-webdav-api version is 1.0-beta-2-SNAPSHOT and not 1.0-beta-2-SNAPSHO**S**T


 was:
my patch contains a stupid typo on archiva parent POM for <dependencyManagement> : plexus-webdav-api version is 1.0-beta-2-SNAPSHOT and not 1.0-beta-2-SNAPSHO*S*T

> regression : server-side relocation fails
> -----------------------------------------
>
>                 Key: MRM-595
>                 URL: http://jira.codehaus.org/browse/MRM-595
>             Project: Archiva
>          Issue Type: Bug
>          Components: WebDAV interface
>    Affects Versions: 1.0-beta-4
>            Reporter: nicolas de loof
>         Attachments: MRM-595.patch, plexus-webdav-api.patch
>
>
> 1.0-beta-4 introduces a regression in maven1 request handling :
> simply try to get :
> http://localhost:8080/archiva/repository/internal/servletapi/jars/servletapi-2.4.jar
> two causes : 
> 1. as fetchContentFromProxies MAY change the request pathInfo when relocation occurs, it MUST be called before resource file is build based on request.getLogicalResource().
> 2. getLogicalResource() is used to get the resource path. The value returned is not affected when the request PathInfo has been changed.
> point 2 may require some changes in plexus DavServerRequest : compute the logical resource on-demand, or add a new public method to set it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MRM-595) regression : server-side relocation fails

Posted by "nicolas de loof (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MRM-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_113886 ] 

nicolas de loof commented on MRM-595:
-------------------------------------

my patch contains a stupid typo on archiva parent POM for <dependencyManagement> : plexus-webdav-api version is 1.0-beta-2-SNAPSHOT and not 1.0-beta-2-SNAPSHO*S*T

> regression : server-side relocation fails
> -----------------------------------------
>
>                 Key: MRM-595
>                 URL: http://jira.codehaus.org/browse/MRM-595
>             Project: Archiva
>          Issue Type: Bug
>          Components: WebDAV interface
>    Affects Versions: 1.0-beta-4
>            Reporter: nicolas de loof
>         Attachments: MRM-595.patch, plexus-webdav-api.patch
>
>
> 1.0-beta-4 introduces a regression in maven1 request handling :
> simply try to get :
> http://localhost:8080/archiva/repository/internal/servletapi/jars/servletapi-2.4.jar
> two causes : 
> 1. as fetchContentFromProxies MAY change the request pathInfo when relocation occurs, it MUST be called before resource file is build based on request.getLogicalResource().
> 2. getLogicalResource() is used to get the resource path. The value returned is not affected when the request PathInfo has been changed.
> point 2 may require some changes in plexus DavServerRequest : compute the logical resource on-demand, or add a new public method to set it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (MRM-595) regression : server-side relocation fails

Posted by "nicolas de loof (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

nicolas de loof updated MRM-595:
--------------------------------

    Attachment: plexus-webdav-api.patch
                MRM-595.patch

- simple change on plexus-webdav-api to support logicalResource beeing changed after the DavServerRequest has been created.

- change on archiva-webapp ProxiedDavServer to fecth from proxied prior to computing the resource File

- testcase to demonstrate the issue and the Fix.

> regression : server-side relocation fails
> -----------------------------------------
>
>                 Key: MRM-595
>                 URL: http://jira.codehaus.org/browse/MRM-595
>             Project: Archiva
>          Issue Type: Bug
>          Components: WebDAV interface
>    Affects Versions: 1.0-beta-4
>            Reporter: nicolas de loof
>         Attachments: MRM-595.patch, plexus-webdav-api.patch
>
>
> 1.0-beta-4 introduces a regression in maven1 request handling :
> simply try to get :
> http://localhost:8080/archiva/repository/internal/servletapi/jars/servletapi-2.4.jar
> two causes : 
> 1. as fetchContentFromProxies MAY change the request pathInfo when relocation occurs, it MUST be called before resource file is build based on request.getLogicalResource().
> 2. getLogicalResource() is used to get the resource path. The value returned is not affected when the request PathInfo has been changed.
> point 2 may require some changes in plexus DavServerRequest : compute the logical resource on-demand, or add a new public method to set it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (MRM-595) regression : server-side relocation fails

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MRM-595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brett Porter closed MRM-595.
----------------------------

      Assignee: Maria Odea Ching
    Resolution: Fixed

> regression : server-side relocation fails
> -----------------------------------------
>
>                 Key: MRM-595
>                 URL: http://jira.codehaus.org/browse/MRM-595
>             Project: Archiva
>          Issue Type: Bug
>          Components: WebDAV interface
>    Affects Versions: 1.0-beta-4
>            Reporter: nicolas de loof
>            Assignee: Maria Odea Ching
>             Fix For: 1.0
>
>         Attachments: MRM-595.patch, plexus-webdav-api.patch
>
>
> 1.0-beta-4 introduces a regression in maven1 request handling :
> simply try to get :
> http://localhost:8080/archiva/repository/internal/servletapi/jars/servletapi-2.4.jar
> two causes : 
> 1. as fetchContentFromProxies MAY change the request pathInfo when relocation occurs, it MUST be called before resource file is build based on request.getLogicalResource().
> 2. getLogicalResource() is used to get the resource path. The value returned is not affected when the request PathInfo has been changed.
> point 2 may require some changes in plexus DavServerRequest : compute the logical resource on-demand, or add a new public method to set it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira