You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2002/02/08 17:04:31 UTC
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core StandardWrapperValve.java
remm 02/02/08 08:04:31
Modified: catalina/src/share/org/apache/catalina/core
StandardWrapperValve.java
Log:
- Don't swallow IOException anymore (bug 6332).
- Craig: is there a reason why this was done ?
Revision Changes Path
1.32 +6 -6 jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardWrapperValve.java
Index: StandardWrapperValve.java
===================================================================
RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardWrapperValve.java,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -r1.31 -r1.32
--- StandardWrapperValve.java 26 Sep 2001 17:48:23 -0000 1.31
+++ StandardWrapperValve.java 8 Feb 2002 16:04:31 -0000 1.32
@@ -1,7 +1,7 @@
/*
- * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardWrapperValve.java,v 1.31 2001/09/26 17:48:23 remm Exp $
- * $Revision: 1.31 $
- * $Date: 2001/09/26 17:48:23 $
+ * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/StandardWrapperValve.java,v 1.32 2002/02/08 16:04:31 remm Exp $
+ * $Revision: 1.32 $
+ * $Date: 2002/02/08 16:04:31 $
*
* ====================================================================
*
@@ -103,7 +103,7 @@
* <code>StandardWrapper</code> container implementation.
*
* @author Craig R. McClanahan
- * @version $Revision: 1.31 $ $Date: 2001/09/26 17:48:23 $
+ * @version $Revision: 1.32 $ $Date: 2002/02/08 16:04:31 $
*/
final class StandardWrapperValve
@@ -247,8 +247,8 @@
sreq.removeAttribute(Globals.JSP_FILE_ATTR);
log(sm.getString("standardWrapper.serviceException",
wrapper.getName()), e);
- ; // No reporting to the response
- ; // No change in availability status
+ throwable = e;
+ exception(request, response, e);
} catch (UnavailableException e) {
sreq.removeAttribute(Globals.JSP_FILE_ATTR);
log(sm.getString("standardWrapper.serviceException",
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core
StandardWrapperValve.java
Posted by "Craig R. McClanahan" <cr...@apache.org>.
On 8 Feb 2002 remm@apache.org wrote:
> Date: 8 Feb 2002 16:04:31 -0000
> From: remm@apache.org
> Reply-To: Tomcat Developers List <to...@jakarta.apache.org>
> To: jakarta-tomcat-4.0-cvs@apache.org
> Subject: cvs commit:
> jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core
> StandardWrapperValve.java
>
> remm 02/02/08 08:04:31
>
> Modified: catalina/src/share/org/apache/catalina/core
> StandardWrapperValve.java
> Log:
> - Don't swallow IOException anymore (bug 6332).
> - Craig: is there a reason why this was done ?
>
Looks to me like this was an oversight when we remodelled the exception
handling -- we definitely need to *not* swallow IOException.
Craig
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>