You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Prasanth Jayachandran (JIRA)" <ji...@apache.org> on 2018/05/16 01:15:00 UTC

[jira] [Commented] (HIVE-19567) Fix flakiness in TestTriggers

    [ https://issues.apache.org/jira/browse/HIVE-19567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476680#comment-16476680 ] 

Prasanth Jayachandran commented on HIVE-19567:
----------------------------------------------

On a relatively slower centos machine I was able to reproduce the flakiness that was either causing assertion error or test timeouts. The reason for that is AbstractJdbcTriggersTest waits until last expected message appears in STDERR here https://github.com/apache/hive/blob/master/itests/hive-unit/src/test/java/org/apache/hive/jdbc/AbstractJdbcTriggersTest.java#L164. 
In the tests, the last expected line json line from WM event summary. When I printed the STDERR, the json output gets printed first followed by text summary. But assertion happens for text first followed by json. When json output appears in stderr while loop is exited and assertion fails as there is no text output. 

I made it consistent. The post hook prints json and text summary and all tests also asserts in the same order (json first and then text). 

> Fix flakiness in TestTriggers
> -----------------------------
>
>                 Key: HIVE-19567
>                 URL: https://issues.apache.org/jira/browse/HIVE-19567
>             Project: Hive
>          Issue Type: Bug
>          Components: Test
>    Affects Versions: 3.1.0
>            Reporter: Prasanth Jayachandran
>            Assignee: Prasanth Jayachandran
>            Priority: Major
>         Attachments: HIVE-19567.1.patch
>
>
> Identified another flakiness in TestTriggersMoveWorkloadManager which can cause intermittent test failures. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)