You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joris Van Remoortere <jo...@gmail.com> on 2015/07/27 09:17:49 UTC
Re: Review Request 36830: Libprocess: Introduced configurable
`UNIMPLEMENTED` macro.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36830/
-----------------------------------------------------------
(Updated July 27, 2015, 7:17 a.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and Michael Park.
Changes
-------
past tense for summary.
Summary (updated)
-----------------
Libprocess: Introduced configurable `UNIMPLEMENTED` macro.
Bugs: MESOS-3122
https://issues.apache.org/jira/browse/MESOS-3122
Repository: mesos
Description
-------
use --enable-static-unimplemented to get compile time errors as opposed
to runtime errors.
Diffs
-----
3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b20000cbb
Diff: https://reviews.apache.org/r/36830/diff/
Testing
-------
created a function with an `UNIMPLEMENTED()` body and verified the runtime error occured when configured by default, and a compile-time error ocurred when configured with `--enable-static-unimplemented`
Thanks,
Joris Van Remoortere
Re: Review Request 36830: Libprocess: Introduced configurable
`UNIMPLEMENTED` macro.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36830/#review93145
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On July 27, 2015, 12:17 a.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36830/
> -----------------------------------------------------------
>
> (Updated July 27, 2015, 12:17 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-3122
> https://issues.apache.org/jira/browse/MESOS-3122
>
>
> Repository: mesos
>
>
> Description
> -------
>
> use --enable-static-unimplemented to get compile time errors as opposed
> to runtime errors.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b20000cbb
>
> Diff: https://reviews.apache.org/r/36830/diff/
>
>
> Testing
> -------
>
> created a function with an `UNIMPLEMENTED()` body and verified the runtime error occured when configured by default, and a compile-time error ocurred when configured with `--enable-static-unimplemented`
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 36830: Libprocess: Introduced configurable
`UNIMPLEMENTED` macro.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36830/#review93803
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On July 31, 2015, 9:53 p.m., Joris Van Remoortere wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36830/
> -----------------------------------------------------------
>
> (Updated July 31, 2015, 9:53 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and Michael Park.
>
>
> Bugs: MESOS-3122
> https://issues.apache.org/jira/browse/MESOS-3122
>
>
> Repository: mesos
>
>
> Description
> -------
>
> use --enable-static-unimplemented to get compile time errors as opposed
> to runtime errors.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b20000cbb
>
> Diff: https://reviews.apache.org/r/36830/diff/
>
>
> Testing
> -------
>
> created a function with an `UNIMPLEMENTED()` body and verified the runtime error occured when configured by default, and a compile-time error ocurred when configured with `--enable-static-unimplemented`
>
>
> Thanks,
>
> Joris Van Remoortere
>
>
Re: Review Request 36830: Libprocess: Introduced configurable
`UNIMPLEMENTED` macro.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36830/
-----------------------------------------------------------
(Updated July 31, 2015, 9:53 p.m.)
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and Michael Park.
Changes
-------
rebased.
Bugs: MESOS-3122
https://issues.apache.org/jira/browse/MESOS-3122
Repository: mesos
Description
-------
use --enable-static-unimplemented to get compile time errors as opposed
to runtime errors.
Diffs (updated)
-----
3rdparty/libprocess/configure.ac 7d1221bd5ddfc4fa816b0bbea0be5c6b20000cbb
Diff: https://reviews.apache.org/r/36830/diff/
Testing
-------
created a function with an `UNIMPLEMENTED()` body and verified the runtime error occured when configured by default, and a compile-time error ocurred when configured with `--enable-static-unimplemented`
Thanks,
Joris Van Remoortere