You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ah...@apache.org on 2013/10/08 23:50:13 UTC

[13/14] git commit: [flex-falcon] [refs/heads/develop] - clean up warnings

clean up warnings


Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/7641a69e
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/7641a69e
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/7641a69e

Branch: refs/heads/develop
Commit: 7641a69e3129adf03d8b018b2fda5ae9491b50ce
Parents: a997ce6
Author: Alex Harui <ah...@apache.org>
Authored: Tue Oct 8 13:42:02 2013 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Tue Oct 8 13:50:59 2013 -0700

----------------------------------------------------------------------
 .../internal/as/codegen/ClassDirectiveProcessor.java      |  1 -
 .../codegen/databinding/BindingDestinationMaker.java      | 10 ----------
 .../internal/tree/as/BaseTypedDefinitionNode.java         |  6 ------
 .../flex/compiler/internal/tree/as/BaseVariableNode.java  |  7 -------
 .../flex/compiler/internal/tree/as/FunctionNode.java      |  1 -
 .../internal/tree/mxml/MXMLPropertySpecifierNode.java     |  3 ---
 6 files changed, 28 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/7641a69e/compiler/src/org/apache/flex/compiler/internal/as/codegen/ClassDirectiveProcessor.java
----------------------------------------------------------------------
diff --git a/compiler/src/org/apache/flex/compiler/internal/as/codegen/ClassDirectiveProcessor.java b/compiler/src/org/apache/flex/compiler/internal/as/codegen/ClassDirectiveProcessor.java
index 1b09064..bf162bb 100644
--- a/compiler/src/org/apache/flex/compiler/internal/as/codegen/ClassDirectiveProcessor.java
+++ b/compiler/src/org/apache/flex/compiler/internal/as/codegen/ClassDirectiveProcessor.java
@@ -54,7 +54,6 @@ import org.apache.flex.compiler.definitions.IClassDefinition;
 import org.apache.flex.compiler.definitions.IConstantDefinition;
 import org.apache.flex.compiler.definitions.IDefinition;
 import org.apache.flex.compiler.definitions.IInterfaceDefinition;
-import org.apache.flex.compiler.definitions.ITypeDefinition;
 import org.apache.flex.compiler.definitions.metadata.IMetaTag;
 import org.apache.flex.compiler.definitions.metadata.IMetaTagAttribute;
 import org.apache.flex.compiler.definitions.references.INamespaceReference;

http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/7641a69e/compiler/src/org/apache/flex/compiler/internal/codegen/databinding/BindingDestinationMaker.java
----------------------------------------------------------------------
diff --git a/compiler/src/org/apache/flex/compiler/internal/codegen/databinding/BindingDestinationMaker.java b/compiler/src/org/apache/flex/compiler/internal/codegen/databinding/BindingDestinationMaker.java
index e68a42c..0e78d5d 100644
--- a/compiler/src/org/apache/flex/compiler/internal/codegen/databinding/BindingDestinationMaker.java
+++ b/compiler/src/org/apache/flex/compiler/internal/codegen/databinding/BindingDestinationMaker.java
@@ -25,20 +25,12 @@ import java.util.LinkedList;
 
 import org.apache.flex.abc.instructionlist.InstructionList;
 import org.apache.flex.abc.semantics.Name;
-import org.apache.flex.abc.semantics.Namespace;
 import org.apache.flex.compiler.definitions.IDefinition;
 import org.apache.flex.compiler.definitions.references.INamespaceReference;
 import org.apache.flex.compiler.internal.as.codegen.Binding;
 import org.apache.flex.compiler.internal.as.codegen.InstructionListNode;
-import org.apache.flex.compiler.internal.as.codegen.LexicalScope;
 import org.apache.flex.compiler.internal.as.codegen.MXMLClassDirectiveProcessor;
-import org.apache.flex.compiler.internal.definitions.DefinitionBase;
 import org.apache.flex.compiler.internal.definitions.NamespaceDefinition;
-import org.apache.flex.compiler.internal.definitions.SetterDefinition;
-import org.apache.flex.compiler.internal.definitions.VariableDefinition;
-import org.apache.flex.compiler.projects.ICompilerProject;
-import org.apache.flex.compiler.scopes.IASScope;
-import org.apache.flex.compiler.scopes.IDefinitionSet;
 import org.apache.flex.compiler.tree.as.IASNode;
 import org.apache.flex.compiler.tree.as.IExpressionNode;
 import org.apache.flex.compiler.tree.mxml.IMXMLDataBindingNode;
@@ -136,10 +128,8 @@ public class BindingDestinationMaker
         {
             IMXMLPropertySpecifierNode psn = (IMXMLPropertySpecifierNode)parent;
             IDefinition d = psn.getDefinition();
-            Name mname = ((DefinitionBase)d).getMName(host.getProject());
             Binding b = host.getInstanceScope().getBinding(d);
             INamespaceReference ns = psn.getDefinition().getNamespaceReference();
-            Namespace n = ns.resolveAETNamespace(host.getProject());
             if (ns != NamespaceDefinition.getPublicNamespaceDefinition())
             {
                 InstructionList insns = new InstructionList();

http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/7641a69e/compiler/src/org/apache/flex/compiler/internal/tree/as/BaseTypedDefinitionNode.java
----------------------------------------------------------------------
diff --git a/compiler/src/org/apache/flex/compiler/internal/tree/as/BaseTypedDefinitionNode.java b/compiler/src/org/apache/flex/compiler/internal/tree/as/BaseTypedDefinitionNode.java
index 8bfc6f6..0b21c6e 100644
--- a/compiler/src/org/apache/flex/compiler/internal/tree/as/BaseTypedDefinitionNode.java
+++ b/compiler/src/org/apache/flex/compiler/internal/tree/as/BaseTypedDefinitionNode.java
@@ -19,28 +19,22 @@
 
 package org.apache.flex.compiler.internal.tree.as;
 
-import org.apache.flex.compiler.common.ASModifier;
 import org.apache.flex.compiler.constants.IASLanguageConstants;
-import org.apache.flex.compiler.definitions.metadata.IMetaTag;
-import org.apache.flex.compiler.definitions.references.INamespaceReference;
 import org.apache.flex.compiler.definitions.references.IReference;
 import org.apache.flex.compiler.definitions.references.ReferenceFactory;
 import org.apache.flex.compiler.internal.definitions.DefinitionBase;
 import org.apache.flex.compiler.internal.definitions.GetterDefinition;
-import org.apache.flex.compiler.internal.definitions.NamespaceDefinition;
 import org.apache.flex.compiler.internal.definitions.ParameterDefinition;
 import org.apache.flex.compiler.internal.definitions.SetterDefinition;
 import org.apache.flex.compiler.internal.definitions.SyntheticBindableGetterDefinition;
 import org.apache.flex.compiler.internal.definitions.SyntheticBindableSetterDefinition;
 import org.apache.flex.compiler.internal.scopes.ASScope;
 import org.apache.flex.compiler.internal.scopes.FunctionScope;
-import org.apache.flex.compiler.internal.tree.as.metadata.MetaTagsNode;
 import org.apache.flex.compiler.parsing.IASToken;
 import org.apache.flex.compiler.tree.as.IIdentifierNode;
 import org.apache.flex.compiler.tree.as.ILanguageIdentifierNode;
 import org.apache.flex.compiler.tree.as.ITypedNode;
 import org.apache.flex.compiler.tree.as.ILanguageIdentifierNode.LanguageIdentifierKind;
-import org.apache.flex.compiler.tree.metadata.IMetaTagsNode;
 
 /**
  * Base class for definitions that have a type associated with them

http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/7641a69e/compiler/src/org/apache/flex/compiler/internal/tree/as/BaseVariableNode.java
----------------------------------------------------------------------
diff --git a/compiler/src/org/apache/flex/compiler/internal/tree/as/BaseVariableNode.java b/compiler/src/org/apache/flex/compiler/internal/tree/as/BaseVariableNode.java
index 3ce33b6..7f25145 100644
--- a/compiler/src/org/apache/flex/compiler/internal/tree/as/BaseVariableNode.java
+++ b/compiler/src/org/apache/flex/compiler/internal/tree/as/BaseVariableNode.java
@@ -24,17 +24,10 @@ import java.util.EnumSet;
 
 import org.apache.flex.compiler.constants.IMetaAttributeConstants;
 import org.apache.flex.compiler.constants.INamespaceConstants;
-import org.apache.flex.compiler.definitions.references.IReference;
 import org.apache.flex.compiler.internal.definitions.ConstantDefinition;
 import org.apache.flex.compiler.internal.definitions.DefinitionBase;
-import org.apache.flex.compiler.internal.definitions.GetterDefinition;
-import org.apache.flex.compiler.internal.definitions.ParameterDefinition;
-import org.apache.flex.compiler.internal.definitions.SetterDefinition;
-import org.apache.flex.compiler.internal.definitions.SyntheticBindableGetterDefinition;
-import org.apache.flex.compiler.internal.definitions.SyntheticBindableSetterDefinition;
 import org.apache.flex.compiler.internal.definitions.VariableDefinition;
 import org.apache.flex.compiler.internal.scopes.ASScope;
-import org.apache.flex.compiler.internal.scopes.FunctionScope;
 import org.apache.flex.compiler.internal.semantics.PostProcessStep;
 import org.apache.flex.compiler.internal.tree.as.parts.IDecorationPart;
 import org.apache.flex.compiler.internal.tree.as.parts.VariableDecorationPart;

http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/7641a69e/compiler/src/org/apache/flex/compiler/internal/tree/as/FunctionNode.java
----------------------------------------------------------------------
diff --git a/compiler/src/org/apache/flex/compiler/internal/tree/as/FunctionNode.java b/compiler/src/org/apache/flex/compiler/internal/tree/as/FunctionNode.java
index 77a79ba..90d7960 100644
--- a/compiler/src/org/apache/flex/compiler/internal/tree/as/FunctionNode.java
+++ b/compiler/src/org/apache/flex/compiler/internal/tree/as/FunctionNode.java
@@ -205,7 +205,6 @@ public class FunctionNode extends BaseTypedDefinitionNode implements IFunctionNo
         if (set.contains(PostProcessStep.POPULATE_SCOPE))
         {
             FunctionDefinition definition = buildDefinition();
-            boolean isBindable = definition.isBindable();
             setDefinition(definition);
 
             // if the parent is an anonymous function, then don't add the function definition to the scope

http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/7641a69e/compiler/src/org/apache/flex/compiler/internal/tree/mxml/MXMLPropertySpecifierNode.java
----------------------------------------------------------------------
diff --git a/compiler/src/org/apache/flex/compiler/internal/tree/mxml/MXMLPropertySpecifierNode.java b/compiler/src/org/apache/flex/compiler/internal/tree/mxml/MXMLPropertySpecifierNode.java
index 5ffd3aa..8644fa0 100644
--- a/compiler/src/org/apache/flex/compiler/internal/tree/mxml/MXMLPropertySpecifierNode.java
+++ b/compiler/src/org/apache/flex/compiler/internal/tree/mxml/MXMLPropertySpecifierNode.java
@@ -37,7 +37,6 @@ import org.apache.flex.compiler.internal.projects.FlexProject;
 import org.apache.flex.compiler.internal.scopes.ASScope;
 import org.apache.flex.compiler.internal.scopes.MXMLFileScope;
 import org.apache.flex.compiler.internal.tree.as.NodeBase;
-import org.apache.flex.compiler.internal.tree.mxml.MXMLNodeBase.MXMLNodeInfo;
 import org.apache.flex.compiler.mxml.IMXMLTagAttributeData;
 import org.apache.flex.compiler.mxml.IMXMLTagData;
 import org.apache.flex.compiler.mxml.IMXMLTextData;
@@ -265,8 +264,6 @@ class MXMLPropertySpecifierNode extends MXMLSpecifierNodeBase implements IMXMLPr
     @Override
     protected void initializeFromTag(MXMLTreeBuilder builder, IMXMLTagData tag)
     {
-        MXMLNodeInfo info = createNodeInfo(builder);
-        
         String propertyTypeName = getPropertyTypeName(builder);
 
         if (propertyTypeName.contains(IASLanguageConstants.Vector + ".<") ||