You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/02/16 19:33:36 UTC

[GitHub] [activemq-artemis] jbertram commented on pull request #3456: ARTEMIS-3117 Cache SslContext in NettyAcceptor to mitigate performance

jbertram commented on pull request #3456:
URL: https://github.com/apache/activemq-artemis/pull/3456#issuecomment-780068689


   I see a handful of issues with this PR:
   
   1. It eliminates the use of `SSLContextFactoryProvider`.
   2. It eliminates any option to use `javax.net.ssl.SSLContext` (i.e. the default JDK provider). It only uses `io.netty.handler.ssl.SslContext` (i.e. the OpenSSL provider).
   
   IMO you should just change `org.apache.activemq.artemis.core.remoting.impl.netty.NettyAcceptor#loadOpenSslEngine` to use `SSLContextFactoryProvider` and then implement a caching OpenSSL SSL context factory like `org.apache.activemq.artemis.core.remoting.impl.ssl.CachingSSLContextFactory`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org