You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/03/13 19:40:11 UTC
Review Request: Fixed gtest environment to filter templated tests with a
typename that includes 'CgroupsIsolationModule'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9906/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
Pulled out of my other review: https://reviews.apache.org/r/9797
Diffs
-----
src/tests/environment.cpp e71c2cf9f45f6cd7d7305a11da701042bd6e22c6
Diff: https://reviews.apache.org/r/9906/diff/
Testing
-------
Thanks,
Ben Mahler
Re: Review Request: Fixed gtest environment to filter templated tests with a
typename that includes 'CgroupsIsolationModule'.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9906/#review17817
-----------------------------------------------------------
src/tests/environment.cpp
<https://reviews.apache.org/r/9906/#comment37779>
This should really take a TestInfo now.
- Benjamin Hindman
On March 13, 2013, 6:40 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9906/
> -----------------------------------------------------------
>
> (Updated March 13, 2013, 6:40 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Pulled out of my other review: https://reviews.apache.org/r/9797
>
>
> Diffs
> -----
>
> src/tests/environment.cpp e71c2cf9f45f6cd7d7305a11da701042bd6e22c6
>
> Diff: https://reviews.apache.org/r/9906/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed gtest environment to filter templated tests with a
typename that includes 'CgroupsIsolationModule'.
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9906/#review17837
-----------------------------------------------------------
Ship it!
First time I've reviewed anything on here, so I apparently missed the check box, but the last review should have had a Ship It.
- Thomas Marshall
On March 13, 2013, 10:01 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9906/
> -----------------------------------------------------------
>
> (Updated March 13, 2013, 10:01 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Pulled out of my other review: https://reviews.apache.org/r/9797
>
>
> Diffs
> -----
>
> src/tests/environment.cpp e71c2cf9f45f6cd7d7305a11da701042bd6e22c6
>
> Diff: https://reviews.apache.org/r/9906/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed gtest environment to filter templated tests with a
typename that includes 'CgroupsIsolationModule'.
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9906/#review17836
-----------------------------------------------------------
src/tests/environment.cpp
<https://reviews.apache.org/r/9906/#comment37801>
You implemented part of this TODO, so you should be able to update the comment.
- Thomas Marshall
On March 13, 2013, 10:01 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9906/
> -----------------------------------------------------------
>
> (Updated March 13, 2013, 10:01 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Pulled out of my other review: https://reviews.apache.org/r/9797
>
>
> Diffs
> -----
>
> src/tests/environment.cpp e71c2cf9f45f6cd7d7305a11da701042bd6e22c6
>
> Diff: https://reviews.apache.org/r/9906/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed gtest environment to filter templated tests with a
typename that includes 'CgroupsIsolationModule'.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9906/#review17846
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 14, 2013, 1:25 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9906/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 1:25 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Pulled out of my other review: https://reviews.apache.org/r/9797
>
>
> Diffs
> -----
>
> src/tests/environment.cpp e71c2cf9f45f6cd7d7305a11da701042bd6e22c6
>
> Diff: https://reviews.apache.org/r/9906/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed gtest environment to filter templated tests with a
typename that includes 'CgroupsIsolationModule'.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9906/#review17853
-----------------------------------------------------------
src/tests/environment.cpp
<https://reviews.apache.org/r/9906/#comment37813>
Hmm, I guess I wasn't clear in my last review. The reason I wanted us to pass the TestInfo is so that we could explicitly check for the CgroupsIsolationModule type parameter rather than check it as a string. :( I guess I'll fix this in another review.
- Benjamin Hindman
On March 14, 2013, 1:25 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9906/
> -----------------------------------------------------------
>
> (Updated March 14, 2013, 1:25 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> Pulled out of my other review: https://reviews.apache.org/r/9797
>
>
> Diffs
> -----
>
> src/tests/environment.cpp e71c2cf9f45f6cd7d7305a11da701042bd6e22c6
>
> Diff: https://reviews.apache.org/r/9906/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed gtest environment to filter templated tests with a
typename that includes 'CgroupsIsolationModule'.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9906/
-----------------------------------------------------------
(Updated March 14, 2013, 1:25 a.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Thomas' review.
Description
-------
Pulled out of my other review: https://reviews.apache.org/r/9797
Diffs (updated)
-----
src/tests/environment.cpp e71c2cf9f45f6cd7d7305a11da701042bd6e22c6
Diff: https://reviews.apache.org/r/9906/diff/
Testing
-------
Thanks,
Ben Mahler
Re: Review Request: Fixed gtest environment to filter templated tests with a
typename that includes 'CgroupsIsolationModule'.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9906/
-----------------------------------------------------------
(Updated March 13, 2013, 10:01 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Benh review.
Description
-------
Pulled out of my other review: https://reviews.apache.org/r/9797
Diffs (updated)
-----
src/tests/environment.cpp e71c2cf9f45f6cd7d7305a11da701042bd6e22c6
Diff: https://reviews.apache.org/r/9906/diff/
Testing
-------
Thanks,
Ben Mahler