You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2019/04/02 17:55:33 UTC
[GitHub] [maven-shade-plugin] rfscholte commented on a change in pull
request #17: [MSHADE-313] - Keep Services
rfscholte commented on a change in pull request #17: [MSHADE-313] - Keep Services
URL: https://github.com/apache/maven-shade-plugin/pull/17#discussion_r271426884
##########
File path: src/main/java/org/apache/maven/plugins/shade/filter/MinijarFilter.java
##########
@@ -138,13 +140,19 @@ private void removeServices( final MavenProject project, final Clazzpath cp )
}
try ( final BufferedReader bufferedReader =
- new BufferedReader( new InputStreamReader( jar.getInputStream( jarEntry ) ) ) )
+ new BufferedReader( new InputStreamReader( jar.getInputStream( jarEntry ), UTF_8 ) ) )
{
for ( String className = bufferedReader.readLine(); className != null;
className = bufferedReader.readLine() )
{
- log.info( className + " was not removed because it is a service" );
- removeClass( cp , className );
+ className = className.split( "#", 2 )[0].trim();
Review comment:
I don't understand this. When I remove this, all still works. Please explain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services