You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/14 19:03:20 UTC

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2914: Move `ScalarValue` tests alongside implementation, move `from_slice` to `datafusion_core`

alamb commented on code in PR #2914:
URL: https://github.com/apache/arrow-datafusion/pull/2914#discussion_r921482370


##########
datafusion/common/src/scalar.rs:
##########
@@ -1987,3 +1987,1176 @@ impl ScalarType<i64> for TimestampNanosecondType {
         ScalarValue::TimestampNanosecond(r, None)
     }
 }
+

Review Comment:
   these tests are moved, verbatim. The only change is that this line
   
   ```rust
       use arrow::{array::*, datatypes::*};
   ```
   
   was removed at the direction of the rust compiler as it was no longer used



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org