You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Artem Baranchuk <ab...@hortonworks.com> on 2014/01/29 23:11:29 UTC
Review Request 17512: Update component name mapping in ClusterDefinition
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17512/
-----------------------------------------------------------
Review request for Ambari and Tom Beerbower.
Bugs: AMBARI-4465
https://issues.apache.org/jira/browse/AMBARI-4465
Repository: ambari
Description
-------
Update component name mapping in ClusterDefinition
Diffs
-----
contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/msi/ClusterDefinition.java 3e95ebd
contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/scom/SQLProviderModule.java 439ac00
contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/msi/ClusterDefinitionTest.java c048df2
contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/scom/TestClusterDefinitionProvider.java 98c6869
contrib/ambari-scom/ambari-scom-server/src/test/resources/clusterproperties_HDP2.txt PRE-CREATION
Diff: https://reviews.apache.org/r/17512/diff/
Testing
-------
Results :
Tests run: 72, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Thanks,
Artem Baranchuk
Re: Review Request 17512: Update component name mapping in ClusterDefinition
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17512/#review33241
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On Jan. 30, 2014, 7:45 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17512/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2014, 7:45 p.m.)
>
>
> Review request for Ambari and Tom Beerbower.
>
>
> Bugs: AMBARI-4465
> https://issues.apache.org/jira/browse/AMBARI-4465
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update component name mapping in ClusterDefinition
>
>
> Diffs
> -----
>
> contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/msi/ClusterDefinition.java 3e95ebd
> contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/scom/SQLProviderModule.java 439ac00
> contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/msi/ClusterDefinitionTest.java c048df2
> contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/scom/TestClusterDefinitionProvider.java 98c6869
> contrib/ambari-scom/ambari-scom-server/src/test/resources/clusterproperties_HDP2.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17512/diff/
>
>
> Testing
> -------
>
> Results :
>
> Tests run: 72, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>
Re: Review Request 17512: Update component name mapping in ClusterDefinition
Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17512/
-----------------------------------------------------------
(Updated Jan. 30, 2014, 7:50 p.m.)
Review request for Ambari and Tom Beerbower.
Bugs: AMBARI-4465
https://issues.apache.org/jira/browse/AMBARI-4465
Repository: ambari
Description
-------
Update component name mapping in ClusterDefinition
Diffs (updated)
-----
contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/msi/ClusterDefinition.java 3e95ebd
contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/scom/SQLProviderModule.java 439ac00
contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/msi/ClusterDefinitionTest.java c048df2
contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/scom/TestClusterDefinitionProvider.java 98c6869
contrib/ambari-scom/ambari-scom-server/src/test/resources/clusterproperties_HDP2.txt PRE-CREATION
Diff: https://reviews.apache.org/r/17512/diff/
Testing
-------
Results :
Tests run: 72, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Thanks,
Artem Baranchuk
Re: Review Request 17512: Update component name mapping in ClusterDefinition
Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17512/
-----------------------------------------------------------
(Updated Jan. 30, 2014, 7:45 p.m.)
Review request for Ambari and Tom Beerbower.
Changes
-------
Import is fixed.
About line
private static final String HOSTS_HEADER = "hosts";
After applying this patch we will be able to use both "Hosts" and "hosts" in cluster.properties file.
Bugs: AMBARI-4465
https://issues.apache.org/jira/browse/AMBARI-4465
Repository: ambari
Description
-------
Update component name mapping in ClusterDefinition
Diffs (updated)
-----
contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/msi/ClusterDefinition.java 3e95ebd
contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/scom/SQLProviderModule.java 439ac00
contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/msi/ClusterDefinitionTest.java c048df2
contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/scom/TestClusterDefinitionProvider.java 98c6869
contrib/ambari-scom/ambari-scom-server/src/test/resources/clusterproperties_HDP2.txt PRE-CREATION
Diff: https://reviews.apache.org/r/17512/diff/
Testing
-------
Results :
Tests run: 72, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
Thanks,
Artem Baranchuk
Re: Review Request 17512: Update component name mapping in ClusterDefinition
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17512/#review33178
-----------------------------------------------------------
Please expand import java.util.*. We should use single class imports instead of *.
This line ...
private static final String HOSTS_HEADER = "hosts";
Is the check that uses this case insensitive now or does it have to be lower case h? We don't want 'Hosts' to fail.
- Tom Beerbower
On Jan. 29, 2014, 10:11 p.m., Artem Baranchuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17512/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2014, 10:11 p.m.)
>
>
> Review request for Ambari and Tom Beerbower.
>
>
> Bugs: AMBARI-4465
> https://issues.apache.org/jira/browse/AMBARI-4465
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Update component name mapping in ClusterDefinition
>
>
> Diffs
> -----
>
> contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/msi/ClusterDefinition.java 3e95ebd
> contrib/ambari-scom/ambari-scom-server/src/main/java/org/apache/ambari/scom/SQLProviderModule.java 439ac00
> contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/msi/ClusterDefinitionTest.java c048df2
> contrib/ambari-scom/ambari-scom-server/src/test/java/org/apache/ambari/scom/TestClusterDefinitionProvider.java 98c6869
> contrib/ambari-scom/ambari-scom-server/src/test/resources/clusterproperties_HDP2.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/17512/diff/
>
>
> Testing
> -------
>
> Results :
>
> Tests run: 72, Failures: 0, Errors: 0, Skipped: 0
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Artem Baranchuk
>
>