You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "marcingrzejszczak (via GitHub)" <gi...@apache.org> on 2023/03/15 13:56:44 UTC
[GitHub] [camel-spring-boot] marcingrzejszczak opened a new pull request, #784: Micrometer observation
marcingrzejszczak opened a new pull request, #784:
URL: https://github.com/apache/camel-spring-boot/pull/784
Spring Boot configuration for
- Camel MicrometerObservation tracer
- Micrometer Observation
- Micrometer Tracing
Micrometer Observation and Micrometer Tracing configuration will be removed for Spring Boot 3.x.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] marcingrzejszczak commented on pull request #784: Micrometer observation
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #784:
URL: https://github.com/apache/camel-spring-boot/pull/784#issuecomment-1485278869
https://github.com/apache/camel-spring-boot/pull/802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] marcingrzejszczak commented on pull request #784: Micrometer observation
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #784:
URL: https://github.com/apache/camel-spring-boot/pull/784#issuecomment-1471531084
> Remove @author tags from javadoc, and the license files in top of the source file should be 100% identical to what we use in the other starters. The ones in this PR are a little bit different.
Yeah, cause I copied this from Spring Boot code. How do we approach this problem? Will a note in the `package-info` be enough to show that this whole package was taken from a different location?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] marcingrzejszczak commented on pull request #784: Micrometer observation
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #784:
URL: https://github.com/apache/camel-spring-boot/pull/784#issuecomment-1470065049
Spring Boot example https://github.com/apache/camel-spring-boot-examples/pull/98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] marcingrzejszczak commented on pull request #784: Micrometer observation
Posted by "marcingrzejszczak (via GitHub)" <gi...@apache.org>.
marcingrzejszczak commented on PR #784:
URL: https://github.com/apache/camel-spring-boot/pull/784#issuecomment-1476090983
Prerequisite - https://github.com/apache/camel/pull/9583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] davsclaus commented on pull request #784: Micrometer observation
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #784:
URL: https://github.com/apache/camel-spring-boot/pull/784#issuecomment-1471465909
Remove `@author` tags from javadoc, and the license files in top of the source file should be 100% identical to what we use in the other starters. The ones in this PR are a little bit different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] davsclaus commented on pull request #784: Micrometer observation
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #784:
URL: https://github.com/apache/camel-spring-boot/pull/784#issuecomment-1485227103
I created a ticket
https://issues.apache.org/jira/browse/CAMEL-19209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] davsclaus commented on pull request #784: Micrometer observation
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #784:
URL: https://github.com/apache/camel-spring-boot/pull/784#issuecomment-1471532455
yeah you can do that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] davsclaus commented on pull request #784: Micrometer observation
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #784:
URL: https://github.com/apache/camel-spring-boot/pull/784#issuecomment-1485045694
We also need PR for main branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-spring-boot] davsclaus merged pull request #784: Micrometer observation
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #784:
URL: https://github.com/apache/camel-spring-boot/pull/784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org