You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2016/09/08 09:19:02 UTC
[jclouds/jclouds-karaf] Added motivation for the bundles module (#80)
We should try to be very clear about the need for these bundles and why we are providing them here.
@demobox Can you have a look at the wording?
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-karaf/pull/80
-- Commit Summary --
* Added motivation for the bundles module
-- File Changes --
A bundles/README.md (10)
-- Patch Links --
https://github.com/jclouds/jclouds-karaf/pull/80.patch
https://github.com/jclouds/jclouds-karaf/pull/80.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/80
Re: [jclouds/jclouds-karaf] Added motivation for the bundles module
(#80)
Posted by Andrew Phillips <no...@github.com>.
+1 - looks good to me. Thanks, @nacx!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/80#issuecomment-245798899
Re: [jclouds/jclouds-karaf] Added motivation for the bundles module
(#80)
Posted by Andrew Phillips <no...@github.com>.
> @@ -0,0 +1,10 @@
> +Apache jclouds-karaf bundles
> +============================
> +
> +This module provides convenience bundles to let jclouds run properly in OSGi environments.
> +Some of the bundles contained here are not publicly available, and others are just repackaged
> +to make them work well with jclouds.
Interesting question: where is this less likely to go out-of-date, do you think - in a README or as comments in the respective POM files?
As for the wording, I'd only just minor changes and a bit less detail (again, given the risk of this going out of date). Something like:
"This module provides bundles required to let jclouds run in OSGi environments. These bundles here may not be publicly available elsewhere, or have been repackaged to work with jclouds."
and then move detailed comments into the POM for each bundle?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/80/files/8aef8a6f4def37a190a13238c7ec1856181d02df#r77990393
Re: [jclouds/jclouds-karaf] Added motivation for the bundles module
(#80)
Posted by Ignasi Barrera <no...@github.com>.
>where is this less likely to go out-of-date, do you think - in a README or as comments in the respective POM files?
Agree with the approach of putting the details in each pom.xml and keeping the README generic.
Changes done!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/80#issuecomment-245602092
Re: [jclouds/jclouds-karaf] Added motivation for the bundles module
(#80)
Posted by Andrew Phillips <no...@github.com>.
Closed #80.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/80#event-789447874
Re: [jclouds/jclouds-karaf] Added motivation for the bundles module
(#80)
Posted by Ignasi Barrera <no...@github.com>.
@nacx pushed 1 commit.
ac1671b Addressed review comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/80/files/8aef8a6f4def37a190a13238c7ec1856181d02df..ac1671bfca796992f2c83020f3e69d2bf0673b82
Re: [jclouds/jclouds-karaf] Added motivation for the bundles module
(#80)
Posted by Andrew Phillips <no...@github.com>.
Merged to master: 522e245. Thanks, Ignasi!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-karaf/pull/80#issuecomment-247077152