You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/17 13:08:42 UTC

[GitHub] [flink] ifndef-SleePy opened a new pull request #9147: [FLINK-11631][test] Harden TaskExecutorITCase

ifndef-SleePy opened a new pull request #9147: [FLINK-11631][test] Harden TaskExecutorITCase
URL: https://github.com/apache/flink/pull/9147
 
 
   ## What is the purpose of the change
   
   * Harden `TaskExecutorITCase#testJobReExecutionAfterTaskExecutorTermination`
   * Harden `TastExecutorITCase#testJobRecoveryWithFailingTaskExecutor`
   
   ## Brief change log
   
   * Improve `MiniCluster` by clearing terminated components in case of an reusing
   * Use a map to keep task managers in `MiniCluster` instead of a list since the task managers might be mutable in some test cases
   * `MiniCluster` exposes more components to `TestingMiniCluster` for enriching testing
   * Replace `terminateTaskExecutor(index)` with `terminateTaskExecutorRandomly()` in `TestingMiniCluster`
   * Add a try-catch for `TastExecutorITCase#testJobRecoveryWithFailingTaskExecutor` to avoid unexpected exception caused by terminating task executor
   
   ## Verifying this change
   
   * This change is already covered by existing tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services