revprop-change hooks and set vs. delete

[John Belmonte <jo...@neggie.net>]

Perhaps both revprop hooks should take an additional flag argument 
indicating whether the change was a deletion?

If I want to use the revprop hooks to log unversioned property changes, 
it seems important to distinguish between deleting a property and 
setting it to a null string.

I guess a property's new status can be obverved from 
post-revprop-change.  However, I don't think there is any way to 
guarantee that another process hasn't modified the same property since 
the revprop change in question.  In any case, this doesn't help if you 
need the info at pre-revprop-change time.

-John

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: revprop-change hooks and set vs. delete

[Tobias Ringström <to...@ringstrom.mine.nu>]

John Belmonte wrote:

> I noticed that the revision you mention didn't update the book, which 
> describes the hook script arguments in detail.

Thanks.  I've added a note to the book's TODO file.

/Tobias


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: revprop-change hooks and set vs. delete

[John Belmonte <jo...@neggie.net>]

I noticed that the revision you mention didn't update the book, which 
describes the hook script arguments in detail.

Thanks,
-John


Tobias Ringström wrote:
> John Belmonte wrote:
> 
>> Perhaps both revprop hooks should take an additional flag argument 
>> indicating whether the change was a deletion?
> 
> 
> Already implemented. Take a look at r12162 which will be in 1.2.
> 
> /Tobias

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: revprop-change hooks and set vs. delete

[Tobias Ringström <to...@ringstrom.mine.nu>]

John Belmonte wrote:

> Perhaps both revprop hooks should take an additional flag argument 
> indicating whether the change was a deletion?

Already implemented. Take a look at r12162 which will be in 1.2.

/Tobias


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org