You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2019/09/25 13:59:20 UTC

[GitHub] [incubator-doris] imay commented on a change in pull request #1878: Reduce memory usage of View object

imay commented on a change in pull request #1878: Reduce memory usage of View object 
URL: https://github.com/apache/incubator-doris/pull/1878#discussion_r328139129
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java
 ##########
 @@ -5126,13 +5126,6 @@ public void createView(CreateViewStmt stmt) throws DdlException {
         View newView = new View(tableId, tableName, columns);
         newView.setComment(stmt.getComment());
         newView.setInlineViewDef(stmt.getInlineViewDef());
-        newView.setOriginalViewDef(stmt.getInlineViewDef());
-        try {
-            newView.init();
 
 Review comment:
   Do we need to keep this init in order to return parse error ASAP?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org