You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/05/22 06:14:37 UTC

[GitHub] [incubator-nuttx] yamt opened a new issue #1100: mkdeps doesn't handle shell special characters

yamt opened a new issue #1100:
URL: https://github.com/apache/incubator-nuttx/issues/1100


   mkdeps uses system() thus a shell to execute cc.
   it doesn't work if you have something like
   
       CFLAGS   += -DMBEDTLS_USER_CONFIG_FILE="<mbedtls/user_config.h>"
   
   because the shell interprets "<" as a redirect.
   
   to fix it, we should do either
   
   * make it shell-quote arguments
   * or, stop using system()
   
   some platforms provide easy ways to do the former.
   eg. https://netbsd.gw.com/cgi-bin/man-cgi?shquote++NetBSD-current
   but unfortunately none of them seems available widely.
   
   i guess the latter approach is more common.
   eg. https://github.com/NetBSD/src/blob/4464250282160188d09bef1ac67ec944b9a8a828/usr.bin/mkdep/mkdep.c#L137-L154
   but i might be a burden for windows. (i don't know)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 closed issue #1100: mkdeps doesn't handle shell special characters

Posted by GitBox <gi...@apache.org>.

xiaoxiang781216 closed issue #1100:
URL: https://github.com/apache/incubator-nuttx/issues/1100


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org