You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/13 09:04:54 UTC
[GitHub] [incubator-doris] HappenLee opened a new pull request, #9547: [Bug][Vectorized] Fix BE crash with delete condition and enable_storage_vectorization
HappenLee opened a new pull request, #9547:
URL: https://github.com/apache/incubator-doris/pull/9547
# Proposed changes
Issue Number: close #9509
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9547: [Bug][Vectorized] Fix BE crash with delete condition and enable_storage_vectorization
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9547:
URL: https://github.com/apache/incubator-doris/pull/9547#issuecomment-1127247005
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee merged pull request #9547: [Bug][Vectorized] Fix BE crash with delete condition and enable_storage_vectorization
Posted by GitBox <gi...@apache.org>.
HappenLee merged PR #9547:
URL: https://github.com/apache/incubator-doris/pull/9547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9547: [Bug][Vectorized] Fix BE crash with delete condition and enable_storage_vectorization
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9547:
URL: https://github.com/apache/incubator-doris/pull/9547#issuecomment-1127247020
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9547: [Bug][Vectorized] Fix BE crash with delete condition and enable_storage_vectorization
Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #9547:
URL: https://github.com/apache/incubator-doris/pull/9547#discussion_r873311365
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -797,7 +797,8 @@ void SegmentIterator::_init_current_block(
auto cid = _schema.column_id(i);
auto column_desc = _schema.column(cid);
- if (_is_pred_column[cid]) { //todo(wb) maybe we can release it after output block
+ if (_is_pred_column[cid] ||
Review Comment:
have add comment in init `_current_return_columns`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9547: [Bug][Vectorized] Fix BE crash with delete condition and enable_storage_vectorization
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #9547:
URL: https://github.com/apache/incubator-doris/pull/9547#discussion_r872905075
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -815,8 +816,10 @@ void SegmentIterator::_init_current_block(
void SegmentIterator::_output_non_pred_columns(vectorized::Block* block) {
SCOPED_RAW_TIMER(&_opts.stats->output_col_ns);
for (auto cid : _non_predicate_columns) {
- block->replace_by_position(_schema_block_id_map[cid],
- std::move(_current_return_columns[cid]));
+ auto loc = _schema_block_id_map[cid];
Review Comment:
std::vector<int> _schema_block_id_map; It is a map from schema column id to column idx in Block, so all loc should less than block->columns(), why do we need add this check?
If we need add this check, any else clause needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9547: [Bug][Vectorized] Fix BE crash with delete condition and enable_storage_vectorization
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #9547:
URL: https://github.com/apache/incubator-doris/pull/9547#discussion_r872904649
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -797,7 +797,8 @@ void SegmentIterator::_init_current_block(
auto cid = _schema.column_id(i);
auto column_desc = _schema.column(cid);
- if (_is_pred_column[cid]) { //todo(wb) maybe we can release it after output block
+ if (_is_pred_column[cid] ||
Review Comment:
Please add some comment here, explain why i will GT block->columns()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] HappenLee commented on a diff in pull request #9547: [Bug][Vectorized] Fix BE crash with delete condition and enable_storage_vectorization
Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #9547:
URL: https://github.com/apache/incubator-doris/pull/9547#discussion_r873311146
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -815,8 +816,10 @@ void SegmentIterator::_init_current_block(
void SegmentIterator::_output_non_pred_columns(vectorized::Block* block) {
SCOPED_RAW_TIMER(&_opts.stats->output_col_ns);
for (auto cid : _non_predicate_columns) {
- block->replace_by_position(_schema_block_id_map[cid],
- std::move(_current_return_columns[cid]));
+ auto loc = _schema_block_id_map[cid];
Review Comment:
have add comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org