You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@eventmesh.apache.org by we...@apache.org on 2022/01/22 09:31:36 UTC

[incubator-eventmesh] branch master updated: [MINOR] Remove the unnecessary boxing (#731)

This is an automated email from the ASF dual-hosted git repository.

wenjun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-eventmesh.git


The following commit(s) were added to refs/heads/master by this push:
     new 8fcddf0  [MINOR] Remove the unnecessary boxing (#731)
8fcddf0 is described below

commit 8fcddf003712ecee03408376b3046a1ec67d9b2d
Author: ZhangJian He <sh...@gmail.com>
AuthorDate: Sat Jan 22 17:31:28 2022 +0800

    [MINOR] Remove the unnecessary boxing (#731)
---
 .../eventmesh/connector/rocketmq/config/ClientConfiguration.java      | 2 +-
 .../runtime/core/protocol/http/processor/HeartBeatProcessor.java      | 2 +-
 .../core/protocol/tcp/client/rebalance/EventmeshRebalanceImpl.java    | 4 ++--
 .../main/java/org/apache/eventmesh/runtime/util/ValueComparator.java  | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/eventmesh-connector-plugin/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/config/ClientConfiguration.java b/eventmesh-connector-plugin/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/config/ClientConfiguration.java
index f51576d..f98f44e 100644
--- a/eventmesh-connector-plugin/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/config/ClientConfiguration.java
+++ b/eventmesh-connector-plugin/eventmesh-connector-rocketmq/src/main/java/org/apache/eventmesh/connector/rocketmq/config/ClientConfiguration.java
@@ -100,7 +100,7 @@ public class ClientConfiguration {
         if (StringUtils.isNotBlank(consumeTimeoutStr)) {
             Preconditions.checkState(StringUtils.isNumeric(consumeTimeoutStr),
                     String.format("%s error", ConfKeys.KEYS_EVENTMESH_ROCKETMQ_CLIENT_CONSUME_TIMEOUT));
-            consumeTimeout = Long.valueOf(consumeTimeoutStr);
+            consumeTimeout = Long.parseLong(consumeTimeoutStr);
         }
 
         String clientPullBatchSizeStr =
diff --git a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/HeartBeatProcessor.java b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/HeartBeatProcessor.java
index 0051afd..24c99ad 100644
--- a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/HeartBeatProcessor.java
+++ b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/HeartBeatProcessor.java
@@ -135,7 +135,7 @@ public class HeartBeatProcessor implements HttpRequestProcessor {
                 String remoteAddr = RemotingHelper.parseChannelRemoteAddr(ctx.channel());
                 String user = heartbeatRequestHeader.getUsername();
                 String pass = heartbeatRequestHeader.getPasswd();
-                int requestCode = Integer.valueOf(heartbeatRequestHeader.getCode());
+                int requestCode = Integer.parseInt(heartbeatRequestHeader.getCode());
                 try {
                     Acl.doAclCheckInHttpHeartbeat(remoteAddr, user, pass, sys, client.topic, requestCode);
                 } catch (Exception e) {
diff --git a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/rebalance/EventmeshRebalanceImpl.java b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/rebalance/EventmeshRebalanceImpl.java
index 4c11b0b..afadcee 100644
--- a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/rebalance/EventmeshRebalanceImpl.java
+++ b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/tcp/client/rebalance/EventmeshRebalanceImpl.java
@@ -169,7 +169,7 @@ public class EventmeshRebalanceImpl implements EventMeshRebalanceStrategy {
             String newProxyIp = eventMeshRecommendResult.get(i).split(":")[0];
             String newProxyPort = eventMeshRecommendResult.get(i).split(":")[1];
             String redirectSessionAddr = EventMeshTcp2Client.redirectClient2NewEventMesh(eventMeshTCPServer, newProxyIp,
-                    Integer.valueOf(newProxyPort), sessionList.get(i), eventMeshTCPServer.getClientSessionGroupMapping());
+                    Integer.parseInt(newProxyPort), sessionList.get(i), eventMeshTCPServer.getClientSessionGroupMapping());
             logger.info("doRebalance,redirect sessionAddr:{}", redirectSessionAddr);
             try {
                 Thread.sleep(eventMeshTCPServer.getEventMeshTCPConfiguration().sleepIntervalInRebalanceRedirectMills);
@@ -192,7 +192,7 @@ public class EventmeshRebalanceImpl implements EventMeshRebalanceStrategy {
                                    Map<String, Integer> clientDistributionMap) throws Exception {
         int sum = 0;
         for (Integer item : clientDistributionMap.values()) {
-            sum += item.intValue();
+            sum += item;
         }
         int currentNum = 0;
         if (clientDistributionMap.get(eventMeshName) != null) {
diff --git a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/ValueComparator.java b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/ValueComparator.java
index d8c8f4d..e383598 100644
--- a/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/ValueComparator.java
+++ b/eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/util/ValueComparator.java
@@ -24,7 +24,7 @@ public class ValueComparator implements Comparator<Map.Entry<String, Integer>> {
     @Override
     public int compare(Map.Entry<String, Integer> x, Map.Entry<String, Integer> y) {
         if (x.getValue().intValue() != y.getValue().intValue()) {
-            return x.getValue().intValue() - y.getValue().intValue();
+            return x.getValue() - y.getValue();
         } else {
             return x.getKey().compareTo(y.getKey());
         }

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: commits-help@eventmesh.apache.org