You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by al...@apache.org on 2019/04/11 02:39:40 UTC
[kudu] branch master updated: [mini-sentry] increase timeout for
Sentry startup
This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
The following commit(s) were added to refs/heads/master by this push:
new a0100ee [mini-sentry] increase timeout for Sentry startup
a0100ee is described below
commit a0100eecd7f90f7e2d7a7ab509a9050e63140fcb
Author: Alexey Serbin <al...@apache.org>
AuthorDate: Wed Apr 10 18:21:57 2019 -0700
[mini-sentry] increase timeout for Sentry startup
This patch increases timeout for Sentry startup time from 60 to 120
seconds. The motivation for this change is spotting flakiness of
some tests from sentry_authz_provider-test where Sentry's JVM was
killed with SIGQUIT (generating a core), and also spotting messages
like below for the tests that hasn't failed:
W0410 23:19:17.437450 7615 mini_sentry.cc:85] Time spent Starting Sentry: real 47.459s user 0.002s sys 0.033s
W0410 23:20:30.217487 7615 mini_sentry.cc:85] Time spent Starting Sentry: real 60.443s user 0.000s sys 0.042s
W0410 23:21:42.836758 7615 mini_sentry.cc:85] Time spent Starting Sentry: real 60.369s user 0.002s sys 0.042s
W0410 23:22:37.729540 7615 mini_sentry.cc:85] Time spent Starting Sentry: real 52.703s user 0.000s sys 0.035s
W0410 23:19:26.633388 32082 mini_sentry.cc:85] Time spent Starting Sentry: real 62.565s user 0.002s sys 0.048s
W0410 23:20:13.020031 32082 mini_sentry.cc:85] Time spent Starting Sentry: real 44.958s user 0.008s sys 0.030s
W0410 23:21:08.531953 32082 mini_sentry.cc:85] Time spent Starting Sentry: real 47.127s user 0.001s sys 0.038s
W0410 23:22:18.332482 32082 mini_sentry.cc:85] Time spent Starting Sentry: real 58.223s user 0.000s sys 0.043s
Change-Id: I555fb017087c6804c47a0c4bcc40d3ae0ee6006f
Reviewed-on: http://gerrit.cloudera.org:8080/12990
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
src/kudu/sentry/mini_sentry.cc | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/kudu/sentry/mini_sentry.cc b/src/kudu/sentry/mini_sentry.cc
index e122c14..b992d4d 100644
--- a/src/kudu/sentry/mini_sentry.cc
+++ b/src/kudu/sentry/mini_sentry.cc
@@ -41,7 +41,7 @@ using std::string;
using std::unique_ptr;
using strings::Substitute;
-static constexpr int kSentryStartTimeoutMs = 60000;
+static constexpr int kSentryStartTimeoutMs = 120000;
namespace kudu {
namespace sentry {
@@ -53,9 +53,9 @@ MiniSentry::~MiniSentry() {
WARN_NOT_OK(Stop(), "Failed to stop MiniSentry");
}
-void MiniSentry::EnableKerberos(std::string krb5_conf,
- std::string service_principal,
- std::string keytab_file) {
+void MiniSentry::EnableKerberos(string krb5_conf,
+ string service_principal,
+ string keytab_file) {
CHECK(!sentry_process_);
CHECK(!krb5_conf.empty());
CHECK(!service_principal.empty());
@@ -118,7 +118,7 @@ Status MiniSentry::Start() {
hms_uris_, IsKerberosEnabled());
}
- map<string, string> env_vars {
+ const map<string, string> env_vars {
{ "JAVA_HOME", java_home },
{ "HADOOP_HOME", hadoop_home },
{ "JAVA_TOOL_OPTIONS", java_options },