You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "rootvector2 (via GitHub)" <gi...@apache.org> on 2026/08/11 05:30:38 UTC

[PR] reject UTF-16 surrogate values in Character converter [commons-cli]

rootvector2 opened a new pull request, #438:
URL: https://github.com/apache/commons-cli/pull/438

   the Character converter in `putDefaultMap` accepts `\uD800` through `\uDFFF` because `Character.isBmpCodePoint` only checks whether the value fits in 16 bits, not whether it is a valid Unicode scalar value; surrogates are reserved for UTF-16 encoding pairs and casting one to char produces an isolated surrogate that corrupts downstream UTF-8 encoding or text normalization.
   
   - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
   - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI).
   - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute?
   - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself.
   - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] reject UTF-16 surrogate values in Character converter [commons-cli]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #438:
URL: https://github.com/apache/commons-cli/pull/438#issuecomment-5251758291

   Closing; duplicate of #436 , same question.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] reject UTF-16 surrogate values in Character converter [commons-cli]

Posted by "rootvector2 (via GitHub)" <gi...@apache.org>.
rootvector2 commented on PR #438:
URL: https://github.com/apache/commons-cli/pull/438#issuecomment-5252501556

   fair enough on the dup. to answer the question here too: you never type the raw character, the converter parses the literal six ascii chars `\uD800` as an escape via the `startsWith("\\u")` branch, so a plain-ascii `--opt \uD800` argument is enough to get an unpaired surrogate char back.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Reject UTF-16 surrogate values in Character converter [commons-cli]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #438:
URL: https://github.com/apache/commons-cli/pull/438


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] reject UTF-16 surrogate values in Character converter [commons-cli]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on PR #438:
URL: https://github.com/apache/commons-cli/pull/438#issuecomment-5268882733

   Reopening: I see your point, thank you for replying. Reviewing again.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] reject UTF-16 surrogate values in Character converter [commons-cli]

Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory closed pull request #438: reject UTF-16 surrogate values in Character converter
URL: https://github.com/apache/commons-cli/pull/438


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org