You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/12 10:25:13 UTC
[GitHub] [flink] matriv opened a new pull request #18340: [FLINK-25351] Introduce `FlinkVersion` as a global enum
matriv opened a new pull request #18340:
URL: https://github.com/apache/flink/pull/18340
## What is the purpose of the change
Rename `MigrationVersion` to `FlinkVersion` and move it to
`flink-core` main (previously test) so that is used globally
and will facilitate the APIs and SQL/TableAPI versioning and
upgrades.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **yes**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper:**no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18340: [FLINK-25351] Introduce `FlinkVersion` as a global enum
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18340:
URL: https://github.com/apache/flink/pull/18340#issuecomment-1010894476
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "18996e0cf4edfde5156e0b671d8fc90732ace975",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29311",
"triggerID" : "18996e0cf4edfde5156e0b671d8fc90732ace975",
"triggerType" : "PUSH"
}, {
"hash" : "8c8b641ce8571b39eb76dcb0b917e03355c8088e",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29323",
"triggerID" : "8c8b641ce8571b39eb76dcb0b917e03355c8088e",
"triggerType" : "PUSH"
}, {
"hash" : "246dde1cdbecd08aa52057218c99b9b0971e29e4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29370",
"triggerID" : "246dde1cdbecd08aa52057218c99b9b0971e29e4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 246dde1cdbecd08aa52057218c99b9b0971e29e4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29370)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18340: [FLINK-25351] Introduce `FlinkVersion` as a global enum
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18340:
URL: https://github.com/apache/flink/pull/18340#issuecomment-1010894476
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "18996e0cf4edfde5156e0b671d8fc90732ace975",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29311",
"triggerID" : "18996e0cf4edfde5156e0b671d8fc90732ace975",
"triggerType" : "PUSH"
}, {
"hash" : "8c8b641ce8571b39eb76dcb0b917e03355c8088e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8c8b641ce8571b39eb76dcb0b917e03355c8088e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18996e0cf4edfde5156e0b671d8fc90732ace975 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29311)
* 8c8b641ce8571b39eb76dcb0b917e03355c8088e UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18340: [FLINK-25351] Introduce `FlinkVersion` as a global enum
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18340:
URL: https://github.com/apache/flink/pull/18340#issuecomment-1010894476
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "18996e0cf4edfde5156e0b671d8fc90732ace975",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29311",
"triggerID" : "18996e0cf4edfde5156e0b671d8fc90732ace975",
"triggerType" : "PUSH"
}, {
"hash" : "8c8b641ce8571b39eb76dcb0b917e03355c8088e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29323",
"triggerID" : "8c8b641ce8571b39eb76dcb0b917e03355c8088e",
"triggerType" : "PUSH"
}, {
"hash" : "246dde1cdbecd08aa52057218c99b9b0971e29e4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29370",
"triggerID" : "246dde1cdbecd08aa52057218c99b9b0971e29e4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8b641ce8571b39eb76dcb0b917e03355c8088e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29323)
* 246dde1cdbecd08aa52057218c99b9b0971e29e4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29370)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on pull request #18340: [FLINK-25351] Introduce `FlinkVersion` as a global enum
Posted by GitBox <gi...@apache.org>.
matriv commented on pull request #18340:
URL: https://github.com/apache/flink/pull/18340#issuecomment-1011905709
@tillrohrmann @twalthr Thank you! Moved to `flink-annotations` please check again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #18340: [FLINK-25351] Introduce `FlinkVersion` as a global enum
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #18340:
URL: https://github.com/apache/flink/pull/18340#discussion_r783200158
##########
File path: flink-core/src/main/java/org/apache/flink/core/FlinkVersion.java
##########
@@ -16,7 +16,7 @@
* limitations under the License.
*/
-package org.apache.flink.testutils.migration;
+package org.apache.flink.core;
Review comment:
True. Maybe the best solution would be to move `FlinkVersion` to the `flink-annotation` module and into the package `org.apache.flink.version` or so.
Sorry for giving you bad advice @matriv.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18340: [FLINK-25351] Introduce `FlinkVersion` as a global enum
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18340:
URL: https://github.com/apache/flink/pull/18340#issuecomment-1010894476
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "18996e0cf4edfde5156e0b671d8fc90732ace975",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29311",
"triggerID" : "18996e0cf4edfde5156e0b671d8fc90732ace975",
"triggerType" : "PUSH"
}, {
"hash" : "8c8b641ce8571b39eb76dcb0b917e03355c8088e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29323",
"triggerID" : "8c8b641ce8571b39eb76dcb0b917e03355c8088e",
"triggerType" : "PUSH"
}, {
"hash" : "246dde1cdbecd08aa52057218c99b9b0971e29e4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "246dde1cdbecd08aa52057218c99b9b0971e29e4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8b641ce8571b39eb76dcb0b917e03355c8088e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29323)
* 246dde1cdbecd08aa52057218c99b9b0971e29e4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18340: [FLINK-25351] Introduce `FlinkVersion` as a global enum
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18340:
URL: https://github.com/apache/flink/pull/18340#issuecomment-1010894476
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "18996e0cf4edfde5156e0b671d8fc90732ace975",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29311",
"triggerID" : "18996e0cf4edfde5156e0b671d8fc90732ace975",
"triggerType" : "PUSH"
}, {
"hash" : "8c8b641ce8571b39eb76dcb0b917e03355c8088e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29323",
"triggerID" : "8c8b641ce8571b39eb76dcb0b917e03355c8088e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8c8b641ce8571b39eb76dcb0b917e03355c8088e Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29323)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] matriv commented on a change in pull request #18340: [FLINK-25351] Introduce `FlinkVersion` as a global enum
Posted by GitBox <gi...@apache.org>.
matriv commented on a change in pull request #18340:
URL: https://github.com/apache/flink/pull/18340#discussion_r783746507
##########
File path: flink-core/src/main/java/org/apache/flink/core/FlinkVersion.java
##########
@@ -16,7 +16,7 @@
* limitations under the License.
*/
-package org.apache.flink.testutils.migration;
+package org.apache.flink.core;
Review comment:
@tillrohrmann No problem, please, I've already moved to `flink-annotations`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #18340: [FLINK-25351] Introduce `FlinkVersion` as a global enum
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #18340:
URL: https://github.com/apache/flink/pull/18340#discussion_r783131385
##########
File path: flink-core/src/main/java/org/apache/flink/core/FlinkVersion.java
##########
@@ -59,22 +59,22 @@ public String toString() {
return versionStr;
}
- public boolean isNewerVersionThan(MigrationVersion otherVersion) {
+ public boolean isNewerVersionThan(FlinkVersion otherVersion) {
return this.ordinal() > otherVersion.ordinal();
}
/** Returns all versions equal to or higher than the selected version. */
- public List<MigrationVersion> orHigher() {
- return Stream.of(MigrationVersion.values())
+ public List<FlinkVersion> orHigher() {
Review comment:
a `Set` might be a better return type here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr closed pull request #18340: [FLINK-25351] Introduce `FlinkVersion` as a global enum
Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #18340:
URL: https://github.com/apache/flink/pull/18340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18340: [FLINK-25351] Introduce `FlinkVersion` as a global enum
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18340:
URL: https://github.com/apache/flink/pull/18340#issuecomment-1010894476
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "18996e0cf4edfde5156e0b671d8fc90732ace975",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29311",
"triggerID" : "18996e0cf4edfde5156e0b671d8fc90732ace975",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18996e0cf4edfde5156e0b671d8fc90732ace975 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29311)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18340: [FLINK-25351] Introduce `FlinkVersion` as a global enum
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18340:
URL: https://github.com/apache/flink/pull/18340#issuecomment-1010894476
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "18996e0cf4edfde5156e0b671d8fc90732ace975",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29311",
"triggerID" : "18996e0cf4edfde5156e0b671d8fc90732ace975",
"triggerType" : "PUSH"
}, {
"hash" : "8c8b641ce8571b39eb76dcb0b917e03355c8088e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29323",
"triggerID" : "8c8b641ce8571b39eb76dcb0b917e03355c8088e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18996e0cf4edfde5156e0b671d8fc90732ace975 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29311)
* 8c8b641ce8571b39eb76dcb0b917e03355c8088e Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29323)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18340: [FLINK-25351] Introduce `FlinkVersion` as a global enum
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18340:
URL: https://github.com/apache/flink/pull/18340#issuecomment-1010894476
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "18996e0cf4edfde5156e0b671d8fc90732ace975",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "18996e0cf4edfde5156e0b671d8fc90732ace975",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18996e0cf4edfde5156e0b671d8fc90732ace975 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #18340: [FLINK-25351] Introduce `FlinkVersion` as a global enum
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #18340:
URL: https://github.com/apache/flink/pull/18340#discussion_r783201356
##########
File path: flink-core/src/main/java/org/apache/flink/core/FlinkVersion.java
##########
@@ -16,7 +16,7 @@
* limitations under the License.
*/
-package org.apache.flink.testutils.migration;
+package org.apache.flink.core;
Review comment:
But I can also move it over once I get to implementing FLIP-197.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18340: [FLINK-25351] Introduce `FlinkVersion` as a global enum
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18340:
URL: https://github.com/apache/flink/pull/18340#issuecomment-1010893632
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 18996e0cf4edfde5156e0b671d8fc90732ace975 (Wed Jan 12 10:30:48 UTC 2022)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18340: [FLINK-25351] Introduce `FlinkVersion` as a global enum
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18340:
URL: https://github.com/apache/flink/pull/18340#issuecomment-1010894476
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "18996e0cf4edfde5156e0b671d8fc90732ace975",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29311",
"triggerID" : "18996e0cf4edfde5156e0b671d8fc90732ace975",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18996e0cf4edfde5156e0b671d8fc90732ace975 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=29311)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] twalthr commented on a change in pull request #18340: [FLINK-25351] Introduce `FlinkVersion` as a global enum
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #18340:
URL: https://github.com/apache/flink/pull/18340#discussion_r783125058
##########
File path: flink-core/src/main/java/org/apache/flink/core/FlinkVersion.java
##########
@@ -16,7 +16,7 @@
* limitations under the License.
*/
-package org.apache.flink.testutils.migration;
+package org.apache.flink.core;
Review comment:
For FLIP-197 this enum must be accessible for `@PublicEvolving` which is in the `flink-annotation` module. Unless we let `flink-annotation` depend on `flink-core`. @tillrohrmann what is your preference here?
We could move the class to the module but does the package `org.apache.flink.annotation` fit? Alternatively, we could also move this to a package `org.apache.flink.FlinkVersion` in the `flink-annotation` module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org