You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Prasad Kashyap (JIRA)" <de...@geronimo.apache.org> on 2006/03/02 20:55:21 UTC
[jira] Created: (GERONIMO-1677) geronimo-dependency-plugin deletion
geronimo-dependency-plugin deletion
-----------------------------------
Key: GERONIMO-1677
URL: http://issues.apache.org/jira/browse/GERONIMO-1677
Project: Geronimo
Type: Sub-task
Reporter: Prasad Kashyap
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1677) Plugin migration to Maven 2:
geronimo-dependency-plugin
Posted by "Jacek Laskowski (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1677?page=comments#action_12370653 ]
Jacek Laskowski commented on GERONIMO-1677:
-------------------------------------------
I'll be trying to figure out a better way to deal with it than the short-term strategy as described by Dave ;) The idea is to create a plugin that will only process dependencies that are declared in the pom of the project the plugin works in *without* transitive dependencies. I think I'll have come up with something by the end of the week (or will have given up by then ;))
> Plugin migration to Maven 2: geronimo-dependency-plugin
> -------------------------------------------------------
>
> Key: GERONIMO-1677
> URL: http://issues.apache.org/jira/browse/GERONIMO-1677
> Project: Geronimo
> Type: Sub-task
> Components: buildsystem
> Versions: 1.x
> Reporter: Prasad Kashyap
> Assignee: Jacek Laskowski
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1677) geronimo-dependency-plugin
deletion
Posted by "Prasad Kashyap (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1677?page=comments#action_12368602 ]
Prasad Kashyap commented on GERONIMO-1677:
------------------------------------------
The geronimo-dependency-plugin is used by the following 6 maven.xml files in
modules/axis
modules/directory
modules/installer-processing
modules/installer-support
modules/jetty
modules/tomcat
Some dependencies in the the project.xml of the above modules are tagged with a <geronimo.dependency> property that is set to true. Based on this property, the plugin generates a geronimo-service.xml in the target/etc/META-INF directory of these modules for inclusion with the module's jar. The deps listed in the geronimo-service.xml files are used by the configuration and the configuration classloader pulls into the same classloader.
Issues:
-----------
1. Dain has some plans for classloader changes at which point we don't know what will happen.
2. The <dependency><property> element that was available under project.xml is no longer available under the pom.xml. So we can't mark those deps the same way.
3. m2 has transitive deps. Maybe once the deps get pruned, there is no need for a separate geronimo-service.xml. Maybe the pom.xml itself will then be good enough.
Proposed Solution (to be implemented in this JIRA)
-----------------------------------------------------------------------
1. We should check in the already generated geronimo-service.xml files into the src tree of the above modules. These files should be packaged with the modules' jars.
2. We should add a comment for those special dependencies in the above 6 modules in the migrated pom.xml in case an equivalent generation has to be done in m2.
3. delete geronimo-dependency-plugin ?
> geronimo-dependency-plugin deletion
> -----------------------------------
>
> Key: GERONIMO-1677
> URL: http://issues.apache.org/jira/browse/GERONIMO-1677
> Project: Geronimo
> Type: Sub-task
> Reporter: Prasad Kashyap
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (GERONIMO-1677) Plugin migration to Maven 2:
geronimo-dependency-plugin
Posted by "Jacek Laskowski (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1677?page=all ]
Jacek Laskowski updated GERONIMO-1677:
--------------------------------------
Component: buildsystem
Summary: Plugin migration to Maven 2: geronimo-dependency-plugin (was: geronimo-dependency-plugin deletion)
Description:
Version: 1.x
Environment:
> Plugin migration to Maven 2: geronimo-dependency-plugin
> -------------------------------------------------------
>
> Key: GERONIMO-1677
> URL: http://issues.apache.org/jira/browse/GERONIMO-1677
> Project: Geronimo
> Type: Sub-task
> Components: buildsystem
> Versions: 1.x
> Reporter: Prasad Kashyap
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1677) Plugin migration to Maven 2:
geronimo-dependency-plugin
Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1677?page=comments#action_12370672 ]
David Jencks commented on GERONIMO-1677:
----------------------------------------
I'm having trouble explaining the problem clearly. With our current geronimo classloaders, there is no way to write a dependency plugin without marking dependencies, as is done with the m1 plugin.
If we have a directed acyclic graph classloader, in which every car file or jar gets a classloader of its own, AND we modify the m2 build to intersperse configurations and modules so that a module such as for example the connector builder gets its connector classes from the connector configuration rather than the connector module jar, then we could write a dependency plugin that collected the non-car dependencies. This is a really long time in the future.
> Plugin migration to Maven 2: geronimo-dependency-plugin
> -------------------------------------------------------
>
> Key: GERONIMO-1677
> URL: http://issues.apache.org/jira/browse/GERONIMO-1677
> Project: Geronimo
> Type: Sub-task
> Components: buildsystem
> Versions: 1.x
> Reporter: Prasad Kashyap
> Assignee: Jacek Laskowski
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (GERONIMO-1677) Plugin migration to Maven 2:
geronimo-dependency-plugin
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1677?page=all ]
Anita Kulshreshtha resolved GERONIMO-1677:
------------------------------------------
Fix Version: 1.2
Resolution: Fixed
geronimo-dependency.xml files generated by m1 build have been checked into the code.
> Plugin migration to Maven 2: geronimo-dependency-plugin
> -------------------------------------------------------
>
> Key: GERONIMO-1677
> URL: http://issues.apache.org/jira/browse/GERONIMO-1677
> Project: Geronimo
> Type: Sub-task
> Security: public(Regular issues)
> Components: buildsystem
> Versions: 1.x
> Reporter: Prasad Kashyap
> Assignee: Jacek Laskowski
> Fix For: 1.2
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1677) geronimo-dependency-plugin
deletion
Posted by "Henri Yandell (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1677?page=comments#action_12368611 ]
Henri Yandell commented on GERONIMO-1677:
-----------------------------------------
Are you suggesting that the m1 use of the plugin would also go away?
ie: 1.5: Remove dependency plugin from project.xml etc.
> geronimo-dependency-plugin deletion
> -----------------------------------
>
> Key: GERONIMO-1677
> URL: http://issues.apache.org/jira/browse/GERONIMO-1677
> Project: Geronimo
> Type: Sub-task
> Reporter: Prasad Kashyap
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1677) Plugin migration to Maven 2:
geronimo-dependency-plugin
Posted by "David Jencks (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1677?page=comments#action_12369756 ]
David Jencks commented on GERONIMO-1677:
----------------------------------------
I believe the only plausible short term strategy for m2 is to check the geronimo-service.xml files generated by the m1 dependency plugin into src. We can revisit this when we have a DirectedAcyclicGraphClassloader as planned for the future. The problem is that with our current classloader structure, a jar including a geronimo-service.xml file is included in a configuration, which also has a bunch of parents (imports). Often many of the m2-required compilation dependencies are also included in one of the parent classloaders. Thus the geronimo-service.xml contains the m2 dependencies with the jars supplied by parents removed. For m2, we could probably include the parent configurations as dependencies to get the same effect, and then geronimo-service.xml would actually have the jar dependencies from pom.xml, but this would involve mixing together the modules and configs builds. My conclusion is that the current generated files need to be checked in, and after the build is working smoothly we can revisit the problem.
> Plugin migration to Maven 2: geronimo-dependency-plugin
> -------------------------------------------------------
>
> Key: GERONIMO-1677
> URL: http://issues.apache.org/jira/browse/GERONIMO-1677
> Project: Geronimo
> Type: Sub-task
> Components: buildsystem
> Versions: 1.x
> Reporter: Prasad Kashyap
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (GERONIMO-1677) geronimo-dependency-plugin
deletion
Posted by "Anita Kulshreshtha (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1677?page=comments#action_12368711 ]
Anita Kulshreshtha commented on GERONIMO-1677:
----------------------------------------------
In M2 builds dependencies.dependency.version property is made available. Please see tomcat pom.xml (G-1645). Adding <version> tag to g-webservice jar
seems to be sufficient. Right now g-service.xml is not added to the jar. If we run into problems at assembly time, we might have to generate it. I think we may not need it.
> geronimo-dependency-plugin deletion
> -----------------------------------
>
> Key: GERONIMO-1677
> URL: http://issues.apache.org/jira/browse/GERONIMO-1677
> Project: Geronimo
> Type: Sub-task
> Reporter: Prasad Kashyap
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (GERONIMO-1677) Plugin migration to Maven 2:
geronimo-dependency-plugin
Posted by "Jacek Laskowski (JIRA)" <de...@geronimo.apache.org>.
[ http://issues.apache.org/jira/browse/GERONIMO-1677?page=all ]
Jacek Laskowski reassigned GERONIMO-1677:
-----------------------------------------
Assign To: Jacek Laskowski
> Plugin migration to Maven 2: geronimo-dependency-plugin
> -------------------------------------------------------
>
> Key: GERONIMO-1677
> URL: http://issues.apache.org/jira/browse/GERONIMO-1677
> Project: Geronimo
> Type: Sub-task
> Components: buildsystem
> Versions: 1.x
> Reporter: Prasad Kashyap
> Assignee: Jacek Laskowski
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira