You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@impala.apache.org by "Fredy Wijaya (Code Review)" <ge...@cloudera.org> on 2019/06/12 01:23:36 UTC

[Impala-ASF-CR] IMPALA-8443: Record time spent in authorization in the runtime profile

Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13353 )

Change subject: IMPALA-8443: Record time spent in authorization in the runtime profile
......................................................................


Patch Set 3:

> Patch Set 3: Patch Set 2 was rebased

Hi Tamas, I saw that you just rebased the patch. Are you going to make a change to make sure the authorization time logged here: https://github.com/apache/impala/blob/ab908d54c22861967f693428ec7d9f6d7008607f/fe/src/main/java/org/apache/impala/authorization/BaseAuthorizationChecker.java#L89 is the same as the one in timeline.markEvent("Authorization finished")?


-- 
To view, visit http://gerrit.cloudera.org:8080/13353
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bb85e57fcc75d41f3eb2911e6d375e0da6f82ae
Gerrit-Change-Number: 13353
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@cloudera.com>
Gerrit-Reviewer: Austin Nobis <an...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Jun 2019 01:23:36 +0000
Gerrit-HasComments: No