[GitHub] [maven] gnodet commented on pull request #947: [MNG-7642] Restore compatibility with flatten-maven-plugin

[GitBox <gi...@apache.org>]

gnodet commented on PR #947:
URL: https://github.com/apache/maven/pull/947#issuecomment-1370845771

   > Not sure about _Restore compatibility_. This just restores as no-op methods. If flatten called them - didn't it do it for some purpose? Will flatten behave as expected or just not throw API incompatibility exception and silently do who-knows-what? Perhaps flatten should be updated instead?
   > 
   > I admit - I have not reviewed this PR/[MNG-7642](https://issues.apache.org/jira/browse/MNG-7642) in detail, so it might all be fine. No need to reply to my comment.
   
   Those classes are actually not used.  But the flatten maven plugin needs to be injected with one instance of `ReportingConverter`, see https://github.com/mojohaus/flatten-maven-plugin/blob/master/src/main/java/org/codehaus/mojo/flatten/ModelBuilderThreadSafetyWorkaround.java#L107
   It will simply pass it to the `ModelBuilder` in the loop method.
   
   The flatten plugin should also be adapted to support the removal of those classes, so that we can get rid of those in 4.1 for example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org