You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/03/28 06:47:52 UTC
[GitHub] [incubator-inlong] kipshi opened a new pull request #3393: [INLONG-3392] Optimize listGroupState in ManagerClient
kipshi opened a new pull request #3393:
URL: https://github.com/apache/incubator-inlong/pull/3393
### Title Name:[INLONG-3392] Optimize listGroupState in ManagerClient
where *XYZ* should be replaced by the actual issue number.
Fixes #3392
### Motivation
### Modifications
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on a change in pull request #3393: [INLONG-3392] Optimize listGroupState in ManagerClient
Posted by GitBox <gi...@apache.org>.
healchow commented on a change in pull request #3393:
URL: https://github.com/apache/incubator-inlong/pull/3393#discussion_r836122841
##########
File path: inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/impl/InlongClientImpl.java
##########
@@ -129,11 +129,11 @@ public InlongGroup forGroup(InlongGroupConf groupConf) {
List<InlongGroupListResponse> groupListResponses = pageInfoResponse.getData().getList();
Map<String, InlongGroupState> groupStateMap = Maps.newHashMap();
groupListResponses.stream().forEach(groupListResponse -> {
- String groupId = groupListResponse.getInlongGroupId();
+ String groupName = groupListResponse.getName();
Review comment:
We will optimize the configuration of inlong_group_id and name in future versions, and it is currently not recommended to do such optimization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow commented on pull request #3393: [INLONG-3392][Manager] List group state in by groupName instead of groupId
Posted by GitBox <gi...@apache.org>.
healchow commented on pull request #3393:
URL: https://github.com/apache/incubator-inlong/pull/3393#issuecomment-1083990070
This update was not enough. We will optimize the groupName and groupId in the next version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] kipshi commented on a change in pull request #3393: [INLONG-3392] Optimize listGroupState in ManagerClient
Posted by GitBox <gi...@apache.org>.
kipshi commented on a change in pull request #3393:
URL: https://github.com/apache/incubator-inlong/pull/3393#discussion_r836138062
##########
File path: inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/impl/InlongClientImpl.java
##########
@@ -129,11 +129,11 @@ public InlongGroup forGroup(InlongGroupConf groupConf) {
List<InlongGroupListResponse> groupListResponses = pageInfoResponse.getData().getList();
Map<String, InlongGroupState> groupStateMap = Maps.newHashMap();
groupListResponses.stream().forEach(groupListResponse -> {
- String groupId = groupListResponse.getInlongGroupId();
+ String groupName = groupListResponse.getName();
Review comment:
Name is recommend as unique key for inlong group, id is a concept which is not universally used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow closed pull request #3393: [INLONG-3392][Manager] List group state in by groupName instead of groupId
Posted by GitBox <gi...@apache.org>.
healchow closed pull request #3393:
URL: https://github.com/apache/incubator-inlong/pull/3393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org