[GitHub] [hadoop] cndaimin commented on a diff in pull request #4104: HDFS-16520. Improve EC pread: avoid potential reading whole block

[GitBox <gi...@apache.org>]

cndaimin commented on code in PR #4104:
URL: https://github.com/apache/hadoop/pull/4104#discussion_r865523712


##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSStripedInputStream.java:
##########
@@ -664,4 +666,70 @@ public void testUnbuffer() throws Exception {
       assertNull(in.parityBuf);
       in.close();
   }
+
+  @Test
+  public void testBlockReader() throws Exception {
+    ecPolicy = StripedFileTestUtil.getDefaultECPolicy(); // RS-6-3-1024k

Review Comment:
   @jojochuang Thanks for your review. Since `TestDFSStripedInputStreamWithRandomECPolicy` extends `TestDFSStripedInputStream`, `testBlockReader` will fail on random EC policy in `TestDFSStripedInputStreamWithRandomECPolicy`. One way is to choose a fixed EC policy as here we do, another way is to extend test case to adapt any EC policy which can be considered too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org