You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (JIRA)" <ji...@apache.org> on 2014/03/03 17:43:21 UTC

[jira] [Comment Edited] (QPID-5579) [Java Broker] Build attribute meta data in the same way for REST API and for AMQP Management

    [ https://issues.apache.org/jira/browse/QPID-5579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918236#comment-13918236 ] 

Robbie Gemmell edited comment on QPID-5579 at 3/3/14 4:42 PM:
--------------------------------------------------------------

https://svn.apache.org/r1571510
===============================
- Not used or properly implemented, appear to duplicate other existing attributes (I think I may have already said basically the same thing on another JIRA - planning a rename? :)). EDIT: I see you already changed this one in https://svn.apache.org/r1573593.
{noformat}
@@ -176,4 +133,62 @@ public interface Queue<X extends Queue<X>> extends ConfiguredObject<X>
     void delete();

     void setNotificationListener(QueueNotificationListener listener);
+
+    @ManagedStatistic
+    long getBytesIn();
+
+    @ManagedStatistic
+    long getBytesOut();
+
+    @ManagedStatistic
+    long getMessagesIn();
+
+    @ManagedStatistic
+    long getMessagesOut();
{noformat}

- Planned change from boolean to int? (I'm assuming yes, for 1.0)
{noformat}
+    @Override
+    public int getLocalTransactionOpen()
+    {
+        long open = _session.getTxnStart() - (_session.getTxnCommits() + _session.getTxnRejects());
+        return (open > 0l) ? 1 : 0;
+    }
{noformat}


was (Author: gemmellr):
https://svn.apache.org/r1571510
===============================
- Not used or properly implemented, appear to duplicate other existing attributes (I think I may have already said basically the same thing on another JIRA - planning a rename? :)).
{noformat}
@@ -176,4 +133,62 @@ public interface Queue<X extends Queue<X>> extends ConfiguredObject<X>
     void delete();

     void setNotificationListener(QueueNotificationListener listener);
+
+    @ManagedStatistic
+    long getBytesIn();
+
+    @ManagedStatistic
+    long getBytesOut();
+
+    @ManagedStatistic
+    long getMessagesIn();
+
+    @ManagedStatistic
+    long getMessagesOut();
{noformat}

- Planned change from boolean to int? (I'm assuming yes, for 1.0)
{noformat}
+    @Override
+    public int getLocalTransactionOpen()
+    {
+        long open = _session.getTxnStart() - (_session.getTxnCommits() + _session.getTxnRejects());
+        return (open > 0l) ? 1 : 0;
+    }
{noformat}

> [Java Broker] Build attribute meta data in the same way for REST API and for AMQP Management
> --------------------------------------------------------------------------------------------
>
>                 Key: QPID-5579
>                 URL: https://issues.apache.org/jira/browse/QPID-5579
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Broker
>            Reporter: Rob Godfrey
>            Assignee: Robbie Gemmell
>             Fix For: 0.27
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org