You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by scwf <gi...@git.apache.org> on 2015/02/12 06:56:56 UTC
[GitHub] spark pull request: [SPARK-5756][SQL] Analyzer should not throw sc...
GitHub user scwf opened a pull request:
https://github.com/apache/spark/pull/4552
[SPARK-5756][SQL] Analyzer should not throw scala.NotImplementedError for legitimate sql
```SELECT CAST(x AS STRING) FROM src``` comes a NotImplementedError:
CliDriver: scala.NotImplementedError: an implementation is missing
at scala.Predef$.$qmark$qmark$qmark(Predef.scala:252)
at org.apache.spark.sql.catalyst.expressions.PrettyAttribute.dataType(namedExpressions.scala:221)
at org.apache.spark.sql.catalyst.expressions.Cast.resolved$lzycompute(Cast.scala:30)
at org.apache.spark.sql.catalyst.expressions.Cast.resolved(Cast.scala:30)
at org.apache.spark.sql.catalyst.expressions.Expression$$anonfun$childrenResolved$1.apply(Expression.scala:68)
at org.apache.spark.sql.catalyst.expressions.Expression$$anonfun$childrenResolved$1.apply(Expression.scala:68)
at scala.collection.LinearSeqOptimized$class.exists(LinearSeqOptimized.scala:80)
at scala.collection.immutable.List.exists(List.scala:84)
at org.apache.spark.sql.catalyst.expressions.Expression.childrenResolved(Expression.scala:68)
at org.apache.spark.sql.catalyst.expressions.Expression.resolved$lzycompute(Expression.scala:56)
at org.apache.spark.sql.catalyst.expressions.Expression.resolved(Expression.scala:56)
at org.apache.spark.sql.catalyst.expressions.NamedExpression.typeSuffix(namedExpressions.scala:62)
at org.apache.spark.sql.catalyst.expressions.Alias.toString(namedExpressions.scala:124)
at org.apache.spark.sql.catalyst.expressions.Expression.prettyString(Expression.scala:78)
at org.apache.spark.sql.catalyst.analysis.Analyzer$CheckResolution$$anonfun$1$$anonfun$7.apply(Analyzer.scala:83)
at org.apache.spark.sql.catalyst.analysis.Analyzer$CheckResolution$$anonfun$1$$anonfun$7.apply(Analyzer.scala:83)
at scala.collection.immutable.Stream.map(Stream.scala:376)
at org.apache.spark.sql.catalyst.analysis.Analyzer$CheckResolution$$anonfun$1.applyOrElse(Analyzer.scala:83)
at org.apache.spark.sql.catalyst.analysis.Analyzer$CheckResolution$$anonfun$1.applyOrElse(Analyzer.scala:81)
at org.apache.spark.sql.catalyst.trees.TreeNode.transformUp(TreeNode.scala:204)
at org.apache.spark.sql.catalyst.analysis.Analyzer$CheckResolution$.apply(Analyzer.scala:81)
at org.apache.spark.sql.catalyst.analysis.Analyzer$CheckResolution$.apply(Analyzer.scala:79)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scwf/spark implemented-error
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/4552.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4552
----
commit 58690c01b0c6238c60ac8640d6cbdd2a095490ab
Author: wangfei <wa...@huawei.com>
Date: 2015-02-12T05:50:24Z
fix implemented-error
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5756][SQL] Analyzer should not throw sc...
Posted by scwf <gi...@git.apache.org>.
Github user scwf commented on the pull request:
https://github.com/apache/spark/pull/4552#issuecomment-74023858
maybe we should catch the exception in typeSuffix to fix this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5756][SQL] Analyzer should not throw sc...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4552#issuecomment-74027537
[Test build #27327 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27327/consoleFull) for PR 4552 at commit [`58690c0`](https://github.com/apache/spark/commit/58690c01b0c6238c60ac8640d6cbdd2a095490ab).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5756][SQL] Analyzer should not throw sc...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/4552#issuecomment-74021800
[Test build #27327 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/27327/consoleFull) for PR 4552 at commit [`58690c0`](https://github.com/apache/spark/commit/58690c01b0c6238c60ac8640d6cbdd2a095490ab).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5756][SQL] Analyzer should not throw sc...
Posted by marmbrus <gi...@git.apache.org>.
Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/4552#issuecomment-74159053
I think this is fixed now by #4558
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5756][SQL] Analyzer should not throw sc...
Posted by scwf <gi...@git.apache.org>.
Github user scwf closed the pull request at:
https://github.com/apache/spark/pull/4552
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5756][SQL] Analyzer should not throw sc...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/4552#issuecomment-74027544
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27327/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org