You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/15 09:28:39 UTC
[GitHub] [incubator-doris] zenoyang commented on a diff in pull request #10161: [imporement]Avoid unnecessary find_codes in predicate
zenoyang commented on code in PR #10161:
URL: https://github.com/apache/incubator-doris/pull/10161#discussion_r897752510
##########
be/src/olap/in_list_predicate.cpp:
##########
@@ -132,15 +136,10 @@ IN_LIST_PRED_COLUMN_BLOCK_EVALUATE(NotInListPredicate, ==)
auto* nested_col_ptr = vectorized::check_and_get_column< \
vectorized::ColumnDictionary<vectorized::Int32>>(nested_col); \
auto& data_array = nested_col_ptr->get_data(); \
- std::vector<bool> selected; \
- nested_col_ptr->find_codes(_values, selected); \
for (uint16_t i = 0; i < *size; i++) { \
uint16_t idx = sel[i]; \
sel[new_size] = idx; \
- const auto& cell_value = data_array[idx]; \
- DCHECK(cell_value < (int64_t)selected.size()); \
- bool ret = !null_bitmap[idx] && (selected[cell_value] OP false); \
- new_size += _opposite ? !ret : ret; \
+ new_size += !null_bitmap[idx] && (_dict_codes[data_array[idx]]); \
Review Comment:
Why ignore `_opposite`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org