You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/03/15 10:03:22 UTC

[GitHub] [tvm] leandron opened a new pull request #7663: [TVMC] Fix to check whether a path passed to --target is strictly a file

leandron opened a new pull request #7663:
URL: https://github.com/apache/tvm/pull/7663


   Fix to check whether a path passed to --target is strictly a file:
   * When we use file with `--target`, the validation in place was only checking whether it was a valid path. For the case in which the path is a directory, it causes a crash when tvmc then tries to open the path.
   * This fix moved the check to be strictly for files, not only a valid path
   
   This was reported in #6302.
   
   cc @mbaret @comaniac 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac commented on pull request #7663: [TVMC] Fix to check whether a path passed to --target is strictly a file

Posted by GitBox <gi...@apache.org>.
comaniac commented on pull request #7663:
URL: https://github.com/apache/tvm/pull/7663#issuecomment-799589193


   Thanks @leandron @d-smirnov 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac merged pull request #7663: [TVMC] Fix to check whether a path passed to --target is strictly a file

Posted by GitBox <gi...@apache.org>.
comaniac merged pull request #7663:
URL: https://github.com/apache/tvm/pull/7663


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org