You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/10/15 22:15:23 UTC
Review Request 39357: Ranger Audit properties for all services should
be recommended to be same as in ranger service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39357/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Bugs: AMBARI-13438
https://issues.apache.org/jira/browse/AMBARI-13438
Repository: ambari
Description
-------
1. Ranger Audit properties for all services should be recommended to be same as the common aduit properties in ranger service
2. Recommend proper values for ranger.audit.solr.zookeepers and xasecure.audit.destination.hdfs.dir in Ranger audit properties
3. Labelling and section ordering tweaks for ranger audit tab
Diffs
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml 0a2a3db
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 9bb21ea
ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-audit.xml a45414d
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-audit.xml aba0357
ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-audit.xml c22d5ee
ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-audit.xml b181f29
ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-audit.xml cce87e3
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml bb6ec00
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml 1ca8a65
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml f180957
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme_version_2.json 6fe7e90
ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-audit.xml 6c2d7c8
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-audit.xml 71c8cce
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py a2bae0f
Diff: https://reviews.apache.org/r/39357/diff/
Testing
-------
Tested on a cluster manually
Verifed that all ambari-server python unit tests passes:
----------------------------------------------------------------------
Ran 236 tests in 6.788s
OK
----------------------------------------------------------------------
Total run:813
Total errors:0
Total failures:0
OK
Thanks,
Jaimin Jetly
Re: Review Request 39357: Ranger Audit properties for all services
should be recommended to be same as in ranger service
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39357/#review102832
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On Oct. 15, 2015, 11:30 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39357/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2015, 11:30 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: AMBARI-13438
> https://issues.apache.org/jira/browse/AMBARI-13438
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Ranger Audit properties for all services should be recommended to be same as the common aduit properties in ranger service
> 2. Recommend proper values for ranger.audit.solr.zookeepers and xasecure.audit.destination.hdfs.dir in Ranger audit properties
> 3. Labelling and section ordering tweaks for ranger audit tab
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml 0a2a3db
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 9bb21ea
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-audit.xml a45414d
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-audit.xml aba0357
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-audit.xml c22d5ee
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-audit.xml b181f29
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-audit.xml cce87e3
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml bb6ec00
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml 1ca8a65
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml f180957
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme_version_2.json 6fe7e90
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-audit.xml 6c2d7c8
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-audit.xml 71c8cce
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py a2bae0f
> ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py da70191
>
> Diff: https://reviews.apache.org/r/39357/diff/
>
>
> Testing
> -------
>
> Tested on a cluster manually
> Verifed that all ambari-server python unit tests passes:
> ----------------------------------------------------------------------
> Ran 236 tests in 6.788s
>
> OK
> ----------------------------------------------------------------------
> Total run:813
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 39357: Ranger Audit properties for all services
should be recommended to be same as in ranger service
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39357/
-----------------------------------------------------------
(Updated Oct. 15, 2015, 11:30 p.m.)
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Changes
-------
Patch adds unit tests
Bugs: AMBARI-13438
https://issues.apache.org/jira/browse/AMBARI-13438
Repository: ambari
Description
-------
1. Ranger Audit properties for all services should be recommended to be same as the common aduit properties in ranger service
2. Recommend proper values for ranger.audit.solr.zookeepers and xasecure.audit.destination.hdfs.dir in Ranger audit properties
3. Labelling and section ordering tweaks for ranger audit tab
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml 0a2a3db
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 9bb21ea
ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-audit.xml a45414d
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-audit.xml aba0357
ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-audit.xml c22d5ee
ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-audit.xml b181f29
ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-audit.xml cce87e3
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml bb6ec00
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml 1ca8a65
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml f180957
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme_version_2.json 6fe7e90
ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-audit.xml 6c2d7c8
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-audit.xml 71c8cce
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py a2bae0f
ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py da70191
Diff: https://reviews.apache.org/r/39357/diff/
Testing
-------
Tested on a cluster manually
Verifed that all ambari-server python unit tests passes:
----------------------------------------------------------------------
Ran 236 tests in 6.788s
OK
----------------------------------------------------------------------
Total run:813
Total errors:0
Total failures:0
OK
Thanks,
Jaimin Jetly
Re: Review Request 39357: Ranger Audit properties for all services
should be recommended to be same as in ranger service
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39357/#review102820
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py (line 486)
<https://reviews.apache.org/r/39357/#comment160607>
Let's add a unit test for this function.
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py (line 523)
<https://reviews.apache.org/r/39357/#comment160606>
Let's add a unit test for this utility function.
- Yusaku Sako
On Oct. 15, 2015, 8:23 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39357/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2015, 8:23 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: AMBARI-13438
> https://issues.apache.org/jira/browse/AMBARI-13438
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 1. Ranger Audit properties for all services should be recommended to be same as the common aduit properties in ranger service
> 2. Recommend proper values for ranger.audit.solr.zookeepers and xasecure.audit.destination.hdfs.dir in Ranger audit properties
> 3. Labelling and section ordering tweaks for ranger audit tab
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml 0a2a3db
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 9bb21ea
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-audit.xml a45414d
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-audit.xml aba0357
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-audit.xml c22d5ee
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-audit.xml b181f29
> ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-audit.xml cce87e3
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml bb6ec00
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml 1ca8a65
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml f180957
> ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme_version_2.json 6fe7e90
> ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-audit.xml 6c2d7c8
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-audit.xml 71c8cce
> ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py a2bae0f
>
> Diff: https://reviews.apache.org/r/39357/diff/
>
>
> Testing
> -------
>
> Tested on a cluster manually
> Verifed that all ambari-server python unit tests passes:
> ----------------------------------------------------------------------
> Ran 236 tests in 6.788s
>
> OK
> ----------------------------------------------------------------------
> Total run:813
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Jaimin Jetly
>
>
Re: Review Request 39357: Ranger Audit properties for all services
should be recommended to be same as in ranger service
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39357/
-----------------------------------------------------------
(Updated Oct. 15, 2015, 8:23 p.m.)
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Bugs: AMBARI-13438
https://issues.apache.org/jira/browse/AMBARI-13438
Repository: ambari
Description
-------
1. Ranger Audit properties for all services should be recommended to be same as the common aduit properties in ranger service
2. Recommend proper values for ranger.audit.solr.zookeepers and xasecure.audit.destination.hdfs.dir in Ranger audit properties
3. Labelling and section ordering tweaks for ranger audit tab
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml 0a2a3db
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 9bb21ea
ambari-server/src/main/resources/stacks/HDP/2.3/services/HBASE/configuration/ranger-hbase-audit.xml a45414d
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/ranger-hdfs-audit.xml aba0357
ambari-server/src/main/resources/stacks/HDP/2.3/services/HIVE/configuration/ranger-hive-audit.xml c22d5ee
ambari-server/src/main/resources/stacks/HDP/2.3/services/KAFKA/configuration/ranger-kafka-audit.xml b181f29
ambari-server/src/main/resources/stacks/HDP/2.3/services/KNOX/configuration/ranger-knox-audit.xml cce87e3
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-admin-site.xml bb6ec00
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-env.xml 1ca8a65
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/configuration/ranger-ugsync-site.xml f180957
ambari-server/src/main/resources/stacks/HDP/2.3/services/RANGER/themes/theme_version_2.json 6fe7e90
ambari-server/src/main/resources/stacks/HDP/2.3/services/STORM/configuration/ranger-storm-audit.xml 6c2d7c8
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/ranger-yarn-audit.xml 71c8cce
ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py a2bae0f
Diff: https://reviews.apache.org/r/39357/diff/
Testing
-------
Tested on a cluster manually
Verifed that all ambari-server python unit tests passes:
----------------------------------------------------------------------
Ran 236 tests in 6.788s
OK
----------------------------------------------------------------------
Total run:813
Total errors:0
Total failures:0
OK
Thanks,
Jaimin Jetly