[GitHub] [spark] jackierwzhang commented on a change in pull request #35385: [SPARK-38094] Enable matching schema column names by field ids

[GitBox <gi...@apache.org>]

jackierwzhang commented on a change in pull request #35385:
URL: https://github.com/apache/spark/pull/35385#discussion_r803320649



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/test/TestSQLContext.scala
##########
@@ -61,7 +61,10 @@ private[sql] object TestSQLContext {
   val overrideConfs: Map[String, String] =
     Map(
       // Fewer shuffle partitions to speed up testing.
-      SQLConf.SHUFFLE_PARTITIONS.key -> "5")
+      SQLConf.SHUFFLE_PARTITIONS.key -> "5",
+      // Enable parquet read field id for tests to ensure correctness
+      SQLConf.PARQUET_FIELD_ID_READ_ENABLED.key -> "true"

Review comment:
       Yeah, but it requires the original schema to contain `parquet.field.id` metadata, which is not present in any of the existing suites, so it should behavior exactly like name matching.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org