[GitHub] [arrow] jonkeane commented on a change in pull request #11898: ARROW-14844_decimal256_take2

[GitBox <gi...@apache.org>]

jonkeane commented on a change in pull request #11898:
URL: https://github.com/apache/arrow/pull/11898#discussion_r765131577



##########
File path: r/R/array.R
##########
@@ -187,7 +187,18 @@ Array$create <- function(x, type = NULL) {
     }
     return(out)
   }
-  vec_to_Array(x, type)
+  tryCatch(
+    vec_to_Array(x, type),
+    error = function(cnd) {
+      if (!is.null(type)) {
+        # try again and then cast
+        vec_to_Array(x, NULL)$cast(type)
+      } else {
+        signalCondition(cnd)
+      }
+    }
+  )
+

Review comment:
       _nods_ yeah I think auto-casting might end up being more confusing than helpful (though hinting that creating then casting manually might work is nice).
   
   Did I miss in here what the blocker is to being able to create these directly / ARROW-11631?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org