You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/03/03 21:52:57 UTC
[kudu-CR] [build] Move the echo subprocess to the kudu-subprocess jar.
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15353
Change subject: [build] Move the echo subprocess to the kudu-subprocess jar.
......................................................................
[build] Move the echo subprocess to the kudu-subprocess jar.
This patch moves the echo subprocess to the kudu-subprocess
jar. This simplifies the build so that a single module is used
for all subprocess implementations.
Change-Id: Id42e55185007905bf831fb9214d5292817e0f8f4
---
D java/kudu-subprocess-echo/build.gradle
R java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/echo/EchoProtocolHandler.java
R java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/echo/EchoSubprocessMain.java
R java/kudu-subprocess/src/test/java/org/apache/kudu/subprocess/echo/TestEchoSubprocess.java
M src/kudu/subprocess/CMakeLists.txt
M src/kudu/subprocess/subprocess_server-test.cc
6 files changed, 11 insertions(+), 61 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/15353/1
--
To view, visit http://gerrit.cloudera.org:8080/15353
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id42e55185007905bf831fb9214d5292817e0f8f4
Gerrit-Change-Number: 15353
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [build] Move the echo subprocess to the kudu-subprocess jar.
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15353 )
Change subject: [build] Move the echo subprocess to the kudu-subprocess jar.
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15353
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id42e55185007905bf831fb9214d5292817e0f8f4
Gerrit-Change-Number: 15353
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 03 Mar 2020 22:33:14 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Move the echo subprocess to the kudu-subprocess jar.
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15353 )
Change subject: [build] Move the echo subprocess to the kudu-subprocess jar.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15353
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id42e55185007905bf831fb9214d5292817e0f8f4
Gerrit-Change-Number: 15353
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 03 Mar 2020 22:17:58 +0000
Gerrit-HasComments: No
[kudu-CR] [build] Move the echo subprocess to the kudu-subprocess jar.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15353 )
Change subject: [build] Move the echo subprocess to the kudu-subprocess jar.
......................................................................
[build] Move the echo subprocess to the kudu-subprocess jar.
This patch moves the echo subprocess to the kudu-subprocess
jar. This simplifies the build so that a single module is used
for all subprocess implementations.
Change-Id: Id42e55185007905bf831fb9214d5292817e0f8f4
Reviewed-on: http://gerrit.cloudera.org:8080/15353
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
---
M build-support/dist_test.py
M build-support/run_dist_test.py
M build-support/verify_jars.pl
D java/kudu-subprocess-echo/build.gradle
R java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/echo/EchoProtocolHandler.java
R java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/echo/EchoSubprocessMain.java
R java/kudu-subprocess/src/test/java/org/apache/kudu/subprocess/echo/TestEchoSubprocess.java
M java/settings.gradle
M src/kudu/subprocess/CMakeLists.txt
M src/kudu/subprocess/subprocess_server-test.cc
10 files changed, 18 insertions(+), 66 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15353
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id42e55185007905bf831fb9214d5292817e0f8f4
Gerrit-Change-Number: 15353
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [build] Move the echo subprocess to the kudu-subprocess jar.
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15353
to look at the new patch set (#2).
Change subject: [build] Move the echo subprocess to the kudu-subprocess jar.
......................................................................
[build] Move the echo subprocess to the kudu-subprocess jar.
This patch moves the echo subprocess to the kudu-subprocess
jar. This simplifies the build so that a single module is used
for all subprocess implementations.
Change-Id: Id42e55185007905bf831fb9214d5292817e0f8f4
---
M build-support/dist_test.py
M build-support/run_dist_test.py
M build-support/verify_jars.pl
D java/kudu-subprocess-echo/build.gradle
R java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/echo/EchoProtocolHandler.java
R java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/echo/EchoSubprocessMain.java
R java/kudu-subprocess/src/test/java/org/apache/kudu/subprocess/echo/TestEchoSubprocess.java
M java/settings.gradle
M src/kudu/subprocess/CMakeLists.txt
M src/kudu/subprocess/subprocess_server-test.cc
10 files changed, 18 insertions(+), 66 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/15353/2
--
To view, visit http://gerrit.cloudera.org:8080/15353
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id42e55185007905bf831fb9214d5292817e0f8f4
Gerrit-Change-Number: 15353
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)