You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/07/16 19:28:59 UTC
[GitHub] [helix] huizhilu opened a new pull request #1823: Merge branch cluster-pause-mode to master
huizhilu opened a new pull request #1823:
URL: https://github.com/apache/helix/pull/1823
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
Resolves #1822
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
The development of cluster freeze mode in a feature branch cluster-pause-mode is completed. We will merge it to the master branch. 13 commits in total.
The feature is tested in a prod like environment. It works as expected.
### Tests
- [ ] The following tests are written for this issue:
(List the names of added unit/integration tests)
- The following is the result of the "mvn test" command on the appropriate module:
Running one more time full tests in helix-core, helix-rest
```
20:22:08,180 [INFO] Tests run: 1282, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4,975.911 s - in TestSuite
20:22:08,707 [INFO]
20:22:08,707 [INFO] Results:
20:22:08,707 [INFO]
20:22:08,707 [INFO] Tests run: 1282, Failures: 0, Errors: 0, Skipped: 0
20:22:08,707 [INFO]
20:22:08,711 [INFO]
20:22:08,711 [INFO] --- jacoco-maven-plugin:0.8.6:report (generate-code-coverage-report) @ helix-core ---
20:22:08,742 [INFO] Loading execution data file /home/hulu/Projects/helix/helix-core/target/jacoco.exec
20:22:09,215 [INFO] Analyzed bundle 'Apache Helix :: Core' with 911 classes
20:22:10,713 [INFO] ------------------------------------------------------------------------
20:22:10,714 [INFO] BUILD SUCCESS
20:22:10,714 [INFO] ------------------------------------------------------------------------
20:22:10,715 [INFO] Total time: 01:23 h
20:22:10,715 [INFO] Finished at: 2021-07-15T20:22:10-07:00
20:22:10,716 [INFO] ------------------------------------------------------------------------
```
(If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] huizhilu merged pull request #1823: Merge cluster freeze feature branch cluster-pause-mode to master
Posted by GitBox <gi...@apache.org>.
huizhilu merged pull request #1823:
URL: https://github.com/apache/helix/pull/1823
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org