[GitHub] [incubator-doris] englefly commented on a diff in pull request #9969: [enhance] improve dict in-predicate evaluate

[GitBox <gi...@apache.org>]

englefly commented on code in PR #9969:
URL: https://github.com/apache/incubator-doris/pull/9969#discussion_r889961022


##########
be/src/olap/in_list_predicate.cpp:
##########
@@ -161,12 +162,14 @@ IN_LIST_PRED_COLUMN_BLOCK_EVALUATE(NotInListPredicate, ==)
                         reinterpret_cast<vectorized::ColumnDictionary<vectorized::Int32>&>(      \
                                 column);                                                         \
                 auto& data_array = dict_col.get_data();                                          \
-                auto dict_codes = dict_col.find_codes(_values);                                  \
+                std::vector<bool> selected;                                                  \
+                size_t dict_word_num = 0;                                                    \

Review Comment:
   I am not sure if there should be an assert(cell_value<dict_word_num).
   I will add this assert.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org