[GitHub] viirya commented on a change in pull request #23562: [SPARK-26619][SQL] Prune the unused serializers from SerializeFromObject

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #23562: [SPARK-26619][SQL] Prune the unused serializers from SerializeFromObject
URL: https://github.com/apache/spark/pull/23562#discussion_r248292589
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ##########
 @@ -561,6 +561,12 @@ object ColumnPruning extends Rule[LogicalPlan] {
     case d @ DeserializeToObject(_, _, child) if !child.outputSet.subsetOf(d.references) =>
       d.copy(child = prunedChild(child, d.references))
 
+    case p @ Project(_, s: SerializeFromObject) if p.references != s.outputSet =>
+      val prunedSerializer = s.serializer.filter { expr =>
+        p.references.contains(expr.toAttribute)
 
 Review comment:
   why? we are not going to get intersected attributes. we want to get part of serializers which are referred by top projection.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org