You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/08/07 00:16:34 UTC
[GitHub] [incubator-superset] ktmud opened a new pull request #10544: bugfix: table chart query mode initial value
ktmud opened a new pull request #10544:
URL: https://github.com/apache/incubator-superset/pull/10544
### SUMMARY
Fix a backward compatibility issue for table charts: when opening an existing table chart before #10113 , whose `query_mode` is not persisted in `form_data`, if the chart is in `Raw Records` mode, the Query Mode control will incorrectly display as "Aggregate".
This is because we calculate the control value in `mapPropsToState` but the mapped value was latter overridden by defaults---a bug introduced by #10264 .
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
#### After
"Raw Records" should be correctly selected for existing charts having only "Columns" control:
### TEST PLAN
Add a Cypress test
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud merged pull request #10544: fix: table chart query mode initial value
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #10544:
URL: https://github.com/apache/incubator-superset/pull/10544
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #10544: fix: table chart query mode initial value
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10544:
URL: https://github.com/apache/incubator-superset/pull/10544#issuecomment-670649483
OH no, this seems to have made it impossible to change query mode. I need to fix this!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org