You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@shiro.apache.org by GitBox <gi...@apache.org> on 2023/01/07 08:39:17 UTC

[GitHub] [shiro] boris-petrov commented on pull request #558: [SHIRO-899] moved the HttpSessionContext Jakarta shim into Shiro pack… (1.11.x)

boris-petrov commented on PR #558:
URL: https://github.com/apache/shiro/pull/558#issuecomment-1374416989

   @lprimak I've got a couple of questions:
   
   1) Isn't this missing the [relocation](https://github.com/apache/shiro/pull/557/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R502) part of the other PR?
   2) Shouldn't the pattern be `jakarta.servlet.http.HttpSessionContext` instead of `javax.servlet.http.HttpSessionContext`?
   3) I'm getting a `java.lang.ClassNotFoundException: jakarta.servlet.http.HttpSessionContext` when using Shiro 1.11.0 in a Jakarta environment (Tomcat 10). I'm definitely not sure if there isn't some problem in my configuration as I'm still figuring that out, however I noticed that change here and wanted to share my experience.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org