[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #5310: Updates to LDAP tests and usage docs

["jamesnetherton (via GitHub)" <gi...@apache.org>]

jamesnetherton commented on code in PR #5310:
URL: https://github.com/apache/camel-quarkus/pull/5310#discussion_r1328491936


##########
integration-tests/ldap/src/main/java/org/apache/camel/quarkus/component/ldap/it/LdapResource.java:
##########
@@ -62,43 +70,43 @@ public class LdapResource {
     @POST
     @Consumes(MediaType.APPLICATION_JSON)
     public void configure(Map<String, String> options) throws Exception {
-        String host = options.get("host");
-        String port = options.get("port");
-        boolean useSSL = Boolean.valueOf(options.get("ssl"));
-        String trustStoreFilename = options.get("trustStore");
-        String trustStorePassword = options.get("trustStorePassword");
-
-        DirContext dirContext = createLdapContext(host, port, useSSL, trustStoreFilename, trustStorePassword);
-        camelContext.getRegistry().bind("ldapserver", dirContext);
+        ldapHost = options.get("host");
+        ldapPort = options.get("port");
+        useSSL = Boolean.valueOf(options.get("ssl"));
+        trustStoreFilename = options.get("trustStore");
+        trustStorePassword = options.get("trustStorePassword");
     }
 
     @Path("/search")
     @GET
     @Produces(MediaType.APPLICATION_JSON)
-    public Response search(@QueryParam("q") String filter) throws Exception {
-        ProducerTemplate producer = camelContext.createProducerTemplate();
-        List<SearchResult> results = producer.requestBody("direct:start", filter, List.class);
-        return Response.ok(convertSearchResults(results)).build();
+    public Response search(@QueryParam("q") String q) throws Exception {

Review Comment:
   I guess it's short for 'query'.
   
   Given Darren is in PTO, I'd vote for merging this and following up later if we really need to.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org