You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/10/05 17:31:44 UTC

[GitHub] [commons-bcel] mureinik edited a comment on pull request #68: BCEL-342 Migrate test suite to JUnit Jupiter

mureinik edited a comment on pull request #68:
URL: https://github.com/apache/commons-bcel/pull/68#issuecomment-703773998


   @garydgregory I can definitely look into that, but I think it would be better to do that in a separate PR.
   This MR is quite large as is, and the more changes we add to it, the harder it would be to rebase. I'd rather see this (or some reviewed/revised variant of it) merged, and then a followup PR can replace the message strings with Suppliers.
   
   Although, of course, if you prefer waiting for it and having the entire thing in one PR, I can definitely do that too - your call.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org