You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/08/09 16:00:17 UTC
[GitHub] [bookkeeper] michaeljmarshall opened a new issue, #3442: Expose rocksDB metrics
michaeljmarshall opened a new issue, #3442:
URL: https://github.com/apache/bookkeeper/issues/3442
**FEATURE REQUEST**
1. Please describe the feature you are requesting.
Expose rocks db metrics (statistics) in the `/metrics` endpoint.
2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have).
Are you currently using any workarounds to address this issue?
This feature should help make it easier to tune the different rocks db configurations.
3. Provide any additional detail on your proposed use case for this feature.
It looks like these statistics are exposed through the `DBOptions` object. I plan to help implement these metrics.
It might be worth putting these metrics behind a feature flag.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] michaeljmarshall commented on issue #3442: Expose rocksDB metrics
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #3442:
URL: https://github.com/apache/bookkeeper/issues/3442#issuecomment-1210136035
The available metrics are here: https://github.com/facebook/rocksdb/blob/d7ebb58cb531031853a183a5771bc4be8c10b45b/include/rocksdb/statistics.h. I am not very familiar with how Bookkeeper uses Rocks DB, so I am not certain which metrics would make the most sense to expose. There are several `_HIT` and `_MISS` metrics that might be meaningful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] michaeljmarshall commented on issue #3442: Expose rocksDB metrics
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on issue #3442:
URL: https://github.com/apache/bookkeeper/issues/3442#issuecomment-1210134353
We could expose the metrics by adding these methods to the `KeyValueStorageRocksDB` class.
```java
public long cacheMisses() throws IOException {
return statistics.getTickerCount(TickerType.BLOCK_CACHE_MISS);
}
public long cacheHits() throws IOException {
return statistics.getTickerCount(TickerType.BLOCK_CACHE_HIT);
}
```
We might have trouble integrating them with the current `StatsLogger` because there is no way to register counters. If you look at the `EntryLocationIndexStats`, you'll see that it relies on registering a gauge. These metrics are not gauges though, so it could lead to some minor confusion when interpreting the metrics output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lhotari commented on issue #3442: Expose rocksDB metrics
Posted by GitBox <gi...@apache.org>.
lhotari commented on issue #3442:
URL: https://github.com/apache/bookkeeper/issues/3442#issuecomment-1210297380
I have added a new metric for entry location index lookups with PR #3444 . That is slightly related. It doesn't go down into the RocksDB level, but it will help detect when RocksDB becomes a bottleneck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org